Skip to:
Content

bbPress.org

Opened 10 years ago

Closed 9 years ago

#1546 closed enhancement (fixed)

New replies can change all topic tags, even if the reply is marked as spam

Reported by: Nightgunner5 Owned by:
Milestone: 2.1 Priority: high
Severity: major Version:
Component: Component - Replies Keywords:
Cc: stephen@…

Description

Instead of setting the topic tags, I suggest adding the tags to the preexisting set and ignoring the new tags if the post does not have a published status.

Offending line: http://bbpress.trac.wordpress.org/browser/branches/plugin/bbp-includes/bbp-reply-functions.php?rev=3255#L276

Change History (6)

#1 @johnjamesjacoby
10 years ago

I really like the idea of having self-policing tags that allow the community to edit them as they feel appropriate. Not a day goes by anymore where a topic ends up with rogue tags in them that are impossible to change with a small moderator team. I may change my mind when tags get blasted out and ruined, but so far the system works well on something like Trac.

Maybe for 2.1 we can explore keeping serialized tag revisions as post_meta with each topic and reply, to take a snapshot of the tags to a topic at that point, so they can be reverted if someone blows through a topic and empties the tags.

#2 @johnjamesjacoby
10 years ago

  • Milestone changed from 2.0 to 2.1
  • Type changed from defect to enhancement
  • Version 1.0.1 deleted

Bumping to 2.1.

#3 @InterMike
10 years ago

Perhaps adding "if user is original topic poster or site admin or moderator, then allow tag editing" in bbPress settings,because everyone on my site keeps on tagging "penis" on every topic O.o

Or at least, could ya help a brother out, and let me know the code I could use to prevent this lol :)

#4 @johnjamesjacoby
10 years ago

  • Milestone changed from 2.1 to Future Release

Punting to future release.

#5 @netweb
9 years ago

  • Cc stephen@… added

#6 @johnjamesjacoby
9 years ago

  • Milestone changed from Future Release to 2.1
  • Resolution set to fixed
  • Status changed from new to closed

Marking replies as spam will revert the topic tags back to what they were when the reply was posted. bbPress keeps a snapshot of them in postmeta, to avoid spam replies damaging existing topic tags.

Considering this, I'm closing this as fixed.

Note: See TracTickets for help on using tickets.