Skip to:
Content

bbPress.org

Opened 13 years ago

Closed 13 years ago

#1523 closed task (blessed) (fixed)

Importers

Reported by: gautamgupta's profile GautamGupta Owned by:
Milestone: 2.0 Priority: high
Severity: major Version:
Component: API - Installation/Upgrade Keywords:
Cc:

Description

We should include importers in the core. We could start with bbPress standalone. Attaching a version of a very prototype thing I've done. I'll likely complete it till tomorrow if someone doesn't beat me to it. :)

Attachments (5)

import_proto.diff (30.2 KB) - added by GautamGupta 13 years ago.
Please take a look at @todos
import_proto.2.diff (33.9 KB) - added by GautamGupta 13 years ago.
Please take a look at @todos
import.diff (39.2 KB) - added by GautamGupta 13 years ago.
import.2.diff (39.6 KB) - added by GautamGupta 13 years ago.
Added a safe guard if the user submits a directory as the path
improvements.diff (15.0 KB) - added by GautamGupta 13 years ago.

Download all attachments as: .zip

Change History (19)

@GautamGupta
13 years ago

Please take a look at @todos

@GautamGupta
13 years ago

Please take a look at @todos

#1 @GautamGupta
13 years ago

Added another patch. The only problem I'm facing is that $bbdb isn't getting set. It is not becoming a db object and hence the import can not be carried on. Didn't dig deep into it.

#2 @cnorris23
13 years ago

Try adding do_action( 'bbpress_init' ); to the functions that need the $bbdb global. You can see it done in BP if you need more help (http://buddypress.trac.wordpress.org/browser/trunk/bp-forums/bp-forums-functions.php#L268).

#3 @GautamGupta
13 years ago

The importer contains codes from BuddyPress and LiveJournal Importer. The only problem right now is that the recounts for topics & replies in forum are failing. I'd also like if someone could test out pingback import.

@GautamGupta
13 years ago

#4 follow-up: @Nightgunner5
13 years ago

Tested, as requested:

http://i.imgur.com/jkQWJl.png

@GautamGupta
13 years ago

Added a safe guard if the user submits a directory as the path

#5 in reply to: ↑ 4 ; follow-up: @GautamGupta
13 years ago

Replying to Nightgunner5:

Tested, as requested

You actually need to submit the path with bb-config.php. Added a safe-guard now. :)

#6 @GautamGupta
13 years ago

Ok, just noticed that we actually ask for the path of the install. Even though we've added a safe guard, we should change that message. :)

#7 in reply to: ↑ 5 @Nightgunner5
13 years ago

Replying to GautamGupta:

Replying to Nightgunner5:

Tested, as requested

You actually need to submit the path with bb-config.php. Added a safe-guard now. :)

I did. It gives exactly the same error message with or without a trailing slash.

#8 @GautamGupta
13 years ago

The line 517 in bbpress.php should be preventing from that to happen. Are you sure that you're using import.2.diff?

#9 @Nightgunner5
13 years ago

define( 'BB_PATH', trailingslashit( dirname( $this->bb_path ) ) ); will always take a directory above the one inputted.

#10 @johnjamesjacoby
13 years ago

(In [3194]) First pass at a stand-alone to plugin converter. Props GautamGupta and Nightgunner5. See #1523.

#11 @GautamGupta
13 years ago

On line 144 in importers/bbpress.php, we're checking for BuddyPress. I think we should do that in bbPress_Importer::autolocate_bb_path() because the user might want to import a non-BuddyPress bbPress standalone install too.

#12 @GautamGupta
13 years ago

Attached a patch with improvements. I think it still doesn't address the freshness issue. That should be fixed by recount anyways - still, it doesn't.

#13 @johnjamesjacoby
13 years ago

(In [3225]) Second round of bbPress standalone importer updates. Props GautamGupta. See #1523.

#14 @johnjamesjacoby
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Closing this as the importer is in core. Please open new tickets for specific importer issues.

Note: See TracTickets for help on using tickets.