Skip to:
Content

Opened 3 years ago

Closed 17 months ago

#1512 closed defect (fixed)

Parent Topic Limit

Reported by: jonkristian Owned by:
Milestone: 2.0 Priority: normal
Severity: normal Version:
Component: Administration Keywords:
Cc: wordpress@…

Description

I have over 50 topics!
Please remove numberposts => 50 on line 397 in bbp-metaboxes.php

Attachments (3)

topic_numberposts.patch (114 bytes) - added by jonkristian 3 years ago.
Removes numberposts from topics dropdown.
topics_numberposts.patch (434 bytes) - added by jonkristian 3 years ago.
1512.diff (766 bytes) - added by MZAWeb 20 months ago.

Download all attachments as: .zip

Change History (11)

jonkristian3 years ago

Removes numberposts from topics dropdown.

comment:1 GautamGupta3 years ago

  • Keywords numberposts parent topic bbp_dropdown removed
  • Milestone set to 2.0
  • Version 1.1-alpha deleted

comment:2 johnjamesjacoby3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3271]) Bump the numberposts limit in bbp_reply_metabox to 250, but allow the args to be filtered so large forums have a way to adjust the query. Fixes #1512.

comment:3 MZAWeb20 months ago

  • Cc wordpress@… added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Any chance we can also add 'order' => 'DESC' to the $args, so as the forum gets bigger, we get the last 250 topics in there instead of the first 250? When editing a reply, I think it's more probable to edit a newer one.

comment:4 gautamgupta20 months ago

It should actually be something like the hyperlink dialog box imo, which offers a search option.

MZAWeb20 months ago

comment:5 follow-up: MZAWeb20 months ago

One easy solution would be checking if the $selected post is not part of the $posts dataset, and add it. 1512.diff has a rough implementation of this.

But I agree that ajaxify this would be cool. I'm wondering how many people actually updates the topic for a reply. Seems a very specific scenario to me.

What if instead of showing the combo we show the title of the parent topic and a link "Change", and when you click that link it makes an ajax call for the combo, with numberposts=-1. So we keep the UI snappy for everyone, but load the whole set for the specific case you need it. I can have a go to implement it, but I'd love to have some feedback before starting coding.

comment:6 in reply to: ↑ 5 MZAWeb20 months ago

Replying to MZAWeb:

One easy solution would be checking if the $selected post is not part of the $posts dataset, and add it. 1512.diff has a rough implementation of this.

This works better than the wp_list_pluck in the if in my patch

!wp_list_filter( $posts, array( 'ID' => intval( $r['selected'] ) ) )

comment:7 MZAWeb20 months ago

Related to #1901

comment:8 MZAWeb17 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

This got fixed in #1901

Note: See TracTickets for help on using tickets.