Skip to:
Content

bbPress.org

Opened 14 years ago

Closed 14 years ago

#1502 closed defect (bug) (fixed)

Merging Topics while Lead Topic Option is set to false

Reported by: gautamgupta's profile GautamGupta Owned by:
Milestone: 2.0 Priority: high
Severity: major Version:
Component: Component - Topics Keywords: has-patch
Cc:

Description

Steps to reproduce:

  1. Have the Lead Topic Option as false
  2. Have a topic X with any number of replies
  3. Have a topic Y with any number of replies
  4. Topic X should be created before topic Y (or reverse X & Y in the steps below)
  5. With source = X, destination = Y, merge the topics.
  6. The source = X's first post (ie. lead post ie. the X topic post) is shown before the topic Y which shouldn't be the case.

Attaching a patch which checks for this and sets the post date of the destination topic a second before the post date of the source topic.

Attachments (1)

topic_merge.diff​ (1.8 KB) - added by GautamGupta 14 years ago.

Download all attachments as: .zip

Change History (2)

@GautamGupta
14 years ago

#1 @johnjamesjacoby
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3017]) When merging two topics together, the destination topic post_date cannot be after the source topic or any merged replies. Fixes #1502. Props GautamGupta for original patch.

Note: See TracTickets for help on using tickets.