Skip to:
Content

bbPress.org

Opened 13 years ago

Closed 13 years ago

#1477 closed enhancement (fixed)

Akismet support

Reported by: nightgunner5's profile Nightgunner5 Owned by:
Milestone: 2.0 Priority: normal
Severity: normal Version:
Component: General - Administration Keywords:
Cc: nightgunner5@…

Description

bb supported Akismet. WP supports Akismet. bbP needs to learn to follow the ways of its elders. In the meantime, I wrote a plugin that should tide us over until it can be incorporated into core.

Attachments (4)

bbp-akismet.php (9.1 KB) - added by Nightgunner5 13 years ago.
spam-posts-are-not-latest.patch (1.4 KB) - added by Nightgunner5 13 years ago.
1477.003.diff (915 bytes) - added by cnorris23 13 years ago.
1444.004.diff (1.1 KB) - added by cnorris23 13 years ago.

Download all attachments as: .zip

Change History (16)

#1 @GautamGupta
13 years ago

Just a note when we implement this: Subscriptions notification function should check if the reply is a spam or not too.

#2 @Nightgunner5
13 years ago

  • Cc nightgunner5@… added

I've been noticing that the spam topics that are marked as spam by the plugin still show up as the latest topic in a forum. I'll have to look into this.

#3 follow-up: @johnjamesjacoby
13 years ago

Do we know if this patch is still good? Do we have confirmation that it's working as expected?

#4 in reply to: ↑ 3 @Nightgunner5
13 years ago

Replying to johnjamesjacoby:

Do we know if this patch is still good? Do we have confirmation that it's working as expected?

It marks spam posts as spam (as expected), but it has a problem with letting spam tags through.

#5 @johnjamesjacoby
13 years ago

(In [3222]) Allow just-in-time manipulation of topic and reply data before creating or editing them. See #1477.

#6 @cnorris23
13 years ago

Add just-in-time manipulation to new_reply and edit_reply tags. Akismet will use the terms filter on a new reply to keep tags, on a reply marked as spam, from being added to the topic. I've almost got a new Akismet patch to post :) Hopefully tonight or tomorrow.

@cnorris23
13 years ago

#7 @johnjamesjacoby
13 years ago

See r3255. Props cnorris23. Sorry I missed it in the commit message.

#8 @johnjamesjacoby
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Closing this to clean up the milestone.

From what I can see, all of the _POST requests have adequate filters on them for allowing Akismet (or any other spam prevention tool) to hook in.

Anyone that's working on (or has) a finished bbPress 2.0 Akismet plugin, please contact me so we can work closely together to code review and finalize it asap.

#9 @Nightgunner5
13 years ago

Posted on IRC, but I'll repost the link here: http://pastebin.com/kvtbZSz0

#10 @cnorris23
13 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Forgot to add the reply_id to the terms filters.

@cnorris23
13 years ago

#11 @cnorris23
13 years ago

Also, the patch filename should be ignored. The patch contents are correct. Just a little brainfart.

#12 @johnjamesjacoby
13 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

See r3268. Fixed again.

Note: See TracTickets for help on using tickets.