Skip to:
Content

bbPress.org

Opened 14 years ago

Closed 14 years ago

Last modified 18 months ago

#1476 closed defect (bug) (fixed)

Registration does not work

Reported by: nightgunner5's profile Nightgunner5 Owned by:
Milestone: 2.0 Priority: highest omg sweet tea
Severity: critical Version:
Component: API - Registration Keywords: has-patch needs-testing
Cc: christofian, peter@…

Description

When trying to register through a page using the registration template, the user is redirected to the login page with ERROR: The password field is empty. They then have to click register at the bottom of that page and use the WordPress default registration page to sign up.

Test case

Attachments (4)

form-bbp_user_register-1.diff (2.4 KB) - added by christofian 14 years ago.
form-bbp_user_register-2.diff (2.4 KB) - added by christofian 14 years ago.
bbpress.css.diff (9.9 KB) - added by christofian 14 years ago.
the updated css file located in bbp-themes/bbp-twentyten/css . Without it, the email field does not get displayed the same way the username field get's displayed.
register.patch (41.7 KB) - added by GautamGupta 14 years ago.
Contains some unrelated docs changes too (in the same files)

Download all attachments as: .zip

Change History (14)

#2 follow-up: @christofian
14 years ago

Found this: http://wordpress.stackexchange.com/questions/10334/wordpress-bbpress-registration-user-unfriendly

I haven't tested it yet, but it might work. I'll let you know when I test it if it works.

#3 in reply to: ↑ 2 @christofian
14 years ago

  • Keywords needs-testing added

Replying to christofian:

Found this: http://wordpress.stackexchange.com/questions/10334/wordpress-bbpress-registration-user-unfriendly

I haven't tested it yet, but it might work. I'll let you know when I test it if it works.

I tried the advice on the link, and I tested it on a multisite setup. With the original code I had gotten that error (The password field is empty), but with the new code I got redirected to wp-signup.php, which displayed another blank registration form. The user I attempted to register using the bbpress interface was not actually registered. There were no errors, but no registration.

The patch I used is attached. Someone should test is on a normal wordpress install (not a multisite one), it might have different results.

#4 @christofian
14 years ago

  • Keywords needs-patch removed

Fixed it. I also added html5 validation to the register page, just for the heck of it. Use form-bbp_user_register-2.diff and upload it bbp-themes/bbp-twentyten/bbpress

Test it please. I'm not sure if it works on multisite...

#5 @christofian
14 years ago

  • Keywords has-patch added

@christofian
14 years ago

the updated css file located in bbp-themes/bbp-twentyten/css . Without it, the email field does not get displayed the same way the username field get's displayed.

#6 @christofian
14 years ago

NOTE: use the updated css file. Otherwise the email field will not be styled correctly.

@GautamGupta
14 years ago

Contains some unrelated docs changes too (in the same files)

#7 @GautamGupta
14 years ago

  • Keywords changed from has-patch, needs-testing to has-patch needs-testing

Can anyone test the just-attached patch?

Todo:

  • Error handling (duplicate email/username etc.)
  • Docs (I realised later on that I hadn't added docs for my own changes, and as usual my bbPress copy is a lot edited, so didn't want to take the burden of re-slicing the patch.) :)

#8 @christofian
14 years ago

  • Cc christofian added

The register page does catch errors (duplicate email/username etc.) However, the errors are displayed on the default wordpress register page, not the bbpress one.

I think that should be an enhancement to be added later on.

#9 @padams
14 years ago

  • Cc peter@… added

#10 @johnjamesjacoby
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2970]) Adjustments to login and register forms to improve behavior and functionality.
Various documentation fixes.
Rename _bbp_topic_status meta to _bbp_status, and add migration routine to updater.
Sanity checks on $wp_query in bbp_pre_get_posts.

Fixes #1476, #1493. Props GautamGupta for original diff.

Note: See TracTickets for help on using tickets.