Subscription checkbox while editing post

[GautamGupta]

When an admin/mod edits another user's post, then the subscription checkbox should be modified to show the poster's subscription status rather than the current logged in user's (and same while updating).

[johnjamesjacoby]

(In [2862]) When editing a topic/post, check for author_id() in bb_is_user_subscribed instead of the current_user. Fixes #1462.

[johnjamesjacoby]

The grammar in that commit message was awful, but at least the bug is fixed. :)

[GautamGupta]

The ​message should be modified too. It should be Notify the author of follow-up posts via email if current user != post author.

ps. We should change followup to follow-up and e-mail to email.

[johnjamesjacoby]

This was fixed in a recent commit.

[GautamGupta]

This ​message still needs to be fixed:

Should be Notify the author of follow-up posts via email when the post author is not the logged in user and Notify me of follow-up posts via email when the post author is the logged in user.

[johnjamesjacoby]

(In [2911]) Change subscription checkbox text if the post is the current users or someone else's. Fixes #1462.

[dimadin]

You have wrong logic in [2911] and I'm surprised you still didn't notice that.

I always get This user should be notified of follow-up posts via email as both administrator and member except when I post a reply.

[dimadin]

On my side this patch fixes issue I mentioned in my previous comment, ie. I always get a right text as both administrator and member.

I'm not sure what status of $is_current is now though.

[johnjamesjacoby]

(In [3524]) Fix incorrect text in subscription label when editing a post. Fixes #1462. Props dimadin. (trunk)