Skip to:
Content

bbPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#1407 closed defect (wontfix)

Tabindex attribute causing issues

Reported by: elfin Owned by:
Milestone: 2.0 Priority: normal
Severity: major Version:
Component: Appearance - Theme Compatibility Keywords:
Cc: elfin

Description

please remove all tabindex attributes from form fields in the bbp-twentyten child theme. They cause so many issues and there is no need for them what so ever.

form-bbp_anonymous.php(8)
form-bbp_anonymous.php(13)
form-bbp_anonymous.php(18)
form-bbp_reply.php(21)
form-bbp_reply.php(26)
form-bbp_reply.php(32)
form-bbp_reply.php(39)
form-bbp_topic.php(21)
form-bbp_topic.php(26)
form-bbp_topic.php(31)
form-bbp_topic.php(46)
form-bbp_topic.php(53)

Change History (9)

#1 @johnjamesjacoby
10 years ago

  • Summary changed from spawn of the devil to Tabindex attribute causing issues

Care to explain what issues they are causing?

It's doubtful they'll be completely removed, but I'm open to alternatives if you have any.

#2 @elfin
10 years ago

For tabindex to be even remotely OK you need to ensure virtually everything that can be is using tabindex - this tends to be impractical for all dynamically created sites.

It leads to confusion when tabbing through a page, normal behaviour is tab through in order, starting at the first 'link' and go through in source order. When you add tabindex you suddenly find yourself jumping around the page because elements with tabindex set take priority and get bumped up the queue and are targetted first.

If elements are in a logical order then tabindex is superfluous and not needed.

The reply by Mathieu Bonnet on this page: http://accessites.org/site/2007/09/a-comparative-accessibility-and-usability/ is perhaps the best description of the issue. (the main page I was thinking of has sadly disappeared).

Along the same lines, but even worse!, is the use of accesskeys, but I'm glad to see they aren't being used.

#3 @GautamGupta
10 years ago

We can probably do something like I did in this patch - introduce bbp_tabindex() and bbp_get_tabindex() which plugin and theme both could use. It'd automatically output the next tabindex value - or we can open up a ticket in WordPress to have some kind of this function 'coz it's needed there too.

#4 @elfin
10 years ago

or remove it in its entirety.

#5 @GautamGupta
10 years ago

@elfin
I read your comment after posting mine and after reading all that, even I think that we should re-consider using tabindexes - it works fine without those too.

#6 @elfin
10 years ago

now if only I could persuade the lead developers of WordPress.

#7 @johnjamesjacoby
10 years ago

  • Milestone changed from Plugin to Plugin - Future Release

Moving to future release. Tab indexes are an integral part of developing with accessibility in mind. There are always arguments for and against things like this, but for now they're staying in the bbp-twentyten theme.

I think we should try to keep hard-coded tab indexes out of the actual core files though, since plugins could come in and modify the order.

#8 @johnjamesjacoby
10 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

Closing as wontfix. The current tabindex function should take ample care of our form fields, and new themes can come around and make changes as needed.

#9 @johnjamesjacoby
9 years ago

  • Component changed from Front-end to Theme Compatability
  • Milestone changed from 2.1 to 2.0
Note: See TracTickets for help on using tickets.