Skip to:
Content

Opened 3 years ago

Closed 3 years ago

#1399 closed defect (fixed)

subscriptions, emails not sent

Reported by: elfin Owned by:
Milestone: 2.0 Priority: normal
Severity: normal Version:
Component: Front-end Keywords: has-patch tested
Cc:

Description

In bbp_notify_subscribers the following appears to always match, causing the subscriptions to not run: (@ line 910)

if ( $reply->post_type != $bbp->reply_id || empty( $reply->post_parent ) )
		return false;

post_type will never equal reply_id! But I'm not sure what should be matched there.

Attachments (1)

1399.diff (2.0 KB) - added by GautamGupta 3 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 GautamGupta3 years ago

As you can see here and here, $reply->post_type is actually $bbp->reply_id. But still, subscriptions aren't working for me too.. they did work when I had originally submitted the patch.

comment:2 elfin3 years ago

Before submitting this I printed out the variables - the post_type was still a, erm, post type. Should it not be using $defaults rather than $reply?

GautamGupta3 years ago

comment:3 GautamGupta3 years ago

For this, we can either compact the values on bbp_new_reply hook or just accept $reply_id in bbp_notify_users(). I've attached a patch with the latter method.

comment:4 GautamGupta3 years ago

  • Keywords has-patch tested added

comment:5 johnjamesjacoby3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2711]) Fixes #1399 props GautamGupta

Note: See TracTickets for help on using tickets.