Skip to:
Content

bbPress.org

Opened 16 years ago

Closed 15 years ago

#1370 closed defect (bug) (fixed)

'Right Now' dashboard cuts totals short when the locale puts commas in numbers eg. 2,345

Reported by: johnconners's profile JohnConners Owned by:
Milestone: 1.0.3 Priority: normal
Severity: normal Version: 1.0.2
Component: General - Administration Keywords: has-patch
Cc:

Description

As in the summary, if you've got, say 2345 users and your locale (UK in my case) formats that number as 2,345 then the 'Right Now' dashboard widget will report 2 users, cutting off everything after the comma. This is caused by attempting to format the value as a number - %d - which is expecting an integer.

I've attached a patch that uses the %s formatter instead and therefore corrects the bug.

Attachments (1)

fix-dashboard-right-now.diff​ (3.2 KB) - added by JohnConners 16 years ago.

Download all attachments as: .zip

Change History (3)

@JohnConners
16 years ago

#1 @GautamGupta
15 years ago

  • Milestone set to 1.0.3
  • Version changed from 1.1-alpha to 1.0.2

Looks good to me.

#2 @johnjamesjacoby
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2802]) Clean up index.php. Number format friendliness. Add some comments. Fixes #1370 props JohnConners

Note: See TracTickets for help on using tickets.