Works On 3.0.1 But Fails To Work On 3.1!

[markmcwilliams]

The problem was first found and talked about in #1334, but after a discussion with JJJ on IRC and a little debugging, along with a few checks on a couple of live sites, it'll register the theme directory in WP 3.0.1 properly but not in WP 3.1 which is very much still in alpha (but still!)

Now register_theme_directory(); has not been touched in the 3.1 cycle, so something else has and now it's just the process of figuring out what and see what we need to do to fix it? :)

[markmcwilliams]

It could very well be a bug in WordPress unreleated to register_theme_directory(); though?

[markmcwilliams]

I had a quick 5 minute chat with Ryan Boren in which he said it was perhaps caused in ​[WP15641] which led to him asking me to comment on ​#WP14911 with a little note, so I guess he's going to have a look into it? (I'll update this ticket with any new info I get and/or find!)

[markmcwilliams]

So Ryan made ​[WP16424] and on a live install, everything looks good at my end!

[elfin]

with the fix I mentioned, it still doesn't work for me with my set up locally:
ie replacing this:

$this->file           = __FILE__;

with

$this->file	  = WP_PLUGIN_DIR.'/bbpress/bbpress.php';

But that causes errors for others by the look of it (though I can't think of any reason why it would!).

I can live with the error as I just add that line in locally. Unless of course you want to put a filter on it so I can change it via a quickie plugin.

So shall we call it closed again?

[johnjamesjacoby]

(In [2650]) Windows local-install friendly themes_dir. Fixes #1358 in a really ugly way but works for all OS's

[markmcwilliams]

Ugly or not JJJ, thanks for that 'fix' which works great, here hopes in time to come that this ugly code can be made to look good? What would you do without dedicated Windows Users like myself? ;)