_bb_time_function_return() ignores GMT offset

[mr_pelle]

As title says, _bb_time_function_return() does not consider bbPress gmt_offset.

According to ​this page, _bb_time_function_return() is referenced 7 times in bbPress source: are we going to replace all those instances with bb_datetime_format_i18n() (or similar gmt_offset-aware) or just change _bb_time_function_return()'s behavior?

[mr_pelle]

Sorry, the correct page is ​this, the other is bb_datetime_format_i18n()'s.

[mr_pelle]

bb_gmdate_i18n() call at line 3559 in functions.bb-template.php was missing the third arg, gmt: I set it to false and that's it. =)

[mr_pelle]

Weird.... my last patch setting "gmt" to false fixes search results time but wrecks front-page, forum and view last post time: my GMT is +2 and all last post times got +4 hours instead of -2, making some Freshness values go "-1 years"! :P
How is this possible??

[mr_pelle]

Probably the best thing is to filter dates and times with i18n functions...

[chrishajer]

(In [2435]) add false parameter to bb_gmdate_i18n(). Fixes #1280. props mr_pelle

[mr_pelle]

Quoting myself:

Weird.... my last patch setting "gmt" to false fixes search results time but wrecks front-page, forum and view last post time: my GMT is +2 and all last post times got +4 hours instead of -2, making some Freshness values go "-1 years"! :P
How is this possible??

The patch wrecks all other last post links, I warned you!

[GautamGupta]

Fixes everything everywhere (related to time), also fixes implausible date feed error

[GautamGupta]

I have attached another patch. Though I have tested it many times with different time zones, more testing would be appreciated.

[mr_pelle]

Replying to GautamGupta:

I have attached another patch. Though I have tested it many times with different time zones, more testing would be appreciated.

I've just finished testing it and works great!

[chrishajer]

(In [2437]) Honor gmt_offset. Fixes #1280. Props GautamGupta, mr_pelle

[mdawaffe]

The localize parameter has nothing to do with gmt offset. It's purpose is to tell bbPress weather or not to localize the time into the current language or not.

For a Japanese install, for example:
localize=false: Fri, 03 Sep 2010 20:33:40 +0000
localize=true: 金, 03 9 月 2010 20:33:40 +0000

This changeset breaks feeds. Reverting, reopening.

We need a new arg for this. gmt=true/false with false being the default? Note, though, that bb_since() requires a GMT time be based, so if format=since, we have to force gmt=true.

[mdawaffe]

(In [2539]) Do not localize times in feeds: restore [2132]. Fixes #1092. See #1280.

[mr_pelle]

Attached a patch based on mdawaffe's comment. Hope I understood it correctly...

[mr_pelle]

Is there anything wrong with my last patch?

[mr_pelle]

Any news?

[GautamGupta]

Replying to mr_pelle:

Attached a patch based on mdawaffe's comment. Hope I understood it correctly...

The patch doesn't work for me. It shows me -1 years in the freshness column of topics table.

[mr_pelle]

It seems to work now, thank you [2132] revert! =)

[mr_pelle]

It works now, thanks to the reverting.