Skip to:
Content

bbPress.org

Opened 16 years ago

Closed 15 years ago

Last modified 14 years ago

#1252 closed enhancement (wontfix)

Admin menu validation fix and basic cleanup in bbPress admin functions file

Reported by: simek's profile Simek Owned by:
Milestone: 1.1 Priority: low
Severity: minor Version:
Component: Back-end Keywords: has-patch tested
Cc:

Description

There is a validation problem because of DIV insertion inside link. Solution how to fix it is simple - just replace DIV with INS tag.

I've also made a basic cleanup in "functions.bb-admin.php" file.

Everything was tested on my test instance of bbPress.

If you like those changes I can prepare more fixes like this and some small code enchantments in future.

Attachments (1)

admin.menu.validation.fix.and.basic.cleanup.patch (18.6 KB) - added by Simek 16 years ago.

Download all attachments as: .zip

Change History (6)

#1 @sambauers
16 years ago

  • Milestone changed from 1.0.1 to 1.1
  • Priority changed from normal to low

I think SPAN should be used instead of INS if this is considered a problem. A SPAN will probably need to have display:block added to it's style as well.

#2 @Simek
16 years ago

We can use here also like you suggested SPAN with "display:block" but this produce new validation warning because SPAN tag shouldn't be empty.

#3 @kevinjohngallagher
16 years ago

  • Milestone changed from 1.1 to 1.5

#4 @johnjamesjacoby
15 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

Closing as wontfix. The stand-alone version uses the same method as WordPress does, and the bbPress plugin for WordPress will inherit a similar issue.

#5 @johnjamesjacoby
14 years ago

  • Milestone changed from Future Release to 1.1
  • Version 1.1-alpha deleted
Note: See TracTickets for help on using tickets.