Skip to:
Content

bbPress.org

Opened 15 years ago

Closed 14 years ago

Last modified 14 years ago

#1243 closed defect (bug) (fixed)

Better Tags Management

Reported by: gautam-gupta's profile Gautam Gupta Owned by:
Milestone: 1.1 Priority: normal
Severity: normal Version:
Component: General - Administration Keywords: has-patch tested
Cc: kevinjohngallagher

Description

When merging a tag, the output which comes is something like:

Number of topics from which the old tag was removed: 1
Number of topics to which the new tag was added: 1
Number of rows deleted from tags table:0
New Tag

Problems:

  • Either the output should be in the template of the admin section, or the template (theme) of the front-end section (forums), a plain page looks very odd
  • The output text can be improved

Attachments (2)

tags.diff (24.6 KB) - added by GautamGupta 15 years ago.
Better Tags Management
tags.2.diff (25.6 KB) - added by GautamGupta 15 years ago.
Better Patch

Download all attachments as: .zip

Change History (17)

#1 @Gautam Gupta
15 years ago

  • Summary changed from Bad output when merging tags to Bad output when merging/destroying Tags

The same is the case when deleting a tag.

#2 @Gautam Gupta
15 years ago

  • Summary changed from Bad output when merging/destroying Tags to Bad output when renaming/merging/destroying Tags

Also same when renaming the tag, and the tag already exists.

#3 @kevinjohngallagher
15 years ago

  • Milestone changed from 1.1 to 1.5

#4 @GautamGupta
15 years ago

  • Keywords has-patch needs-testing added; merge tags removed
  • Milestone changed from 1.5 to 1.1
  • Priority changed from normal to high
  • Summary changed from Bad output when renaming/merging/destroying Tags to Better Tags Management

I'm attaching a patch which does the following:

  • Removes the 3 files - tag-remove.php, tag-merge.php, tag-rename.php from bb-admin and instead adds a new tags.php file. When you do anything to tag (from tag management form on the tag page), you would go to tags.php which would display a nice message about the recent action in the admin panel design layout and links to go back (to forum if tag is deleted, to new tag if tag is merged or renamed).
  • tags.php also acts like in administration page for tags, has search, order and bulk actions (destroying and merging) and can be used by plugins. The user can go to the page by clicking that Tags tab in the menu in admin panel.

I think this can get into 1.1 after a little bit of more testing.

@GautamGupta
15 years ago

Better Tags Management

#5 @GautamGupta
15 years ago

And the patch also does some fixes in functions.bb-topic-tags.php like removing the user of deprecated function and typecasting to prevent array function errors.

#6 @kevinjohngallagher
15 years ago

  • Cc kevinjohngallagher added
  • Priority changed from high to low

Tags are over-rated. People simply don't use them - especially non-techy people who see the value. We have 7038 topics on bbPress.org and yet 35/39 Tags have less than 25 topics, the other 4 have more (but pagination doesn't work in the new theme). Even if we don't attempt to count duplicates, bbpress.org has less than 10% of all topics tagged. If we were to check for duplicates, it would definately half.

Tags are a nice to have. But this has been around for almost 2 years, lets move it to teh next Milestone as it's def not a priority:high. Especially as it has 0 impact on users, and only admins who care abotu tags. We have to try and keep a grip on the scope creep.

#7 @GautamGupta
15 years ago

  • Priority changed from low to normal

I have a friend, whose forums are based on sports. People write there as they have passion for sports and sometimes some people really write huge tags or a similar to ones that already exists or something that can't be called a tag. And when they are displayed on the front page, it doesn't look good. Going to each tag and deleting/merging/renaming is possible but a lot time consuming. Therefore tags administration is also very much necessary as other things. The patch also removes those plain white pages when you do anything with the tag (from the tag page).

@GautamGupta
15 years ago

Better Patch

#8 follow-up: @GautamGupta
15 years ago

  • Keywords tested added; needs-testing removed
  • Version changed from 1.0.2 to 1.1-alpha

Attached another patch which is ready to go into the core.

#9 @GautamGupta
15 years ago

  • Milestone changed from 1.1 to 1.5

#10 @kevinjohngallagher
15 years ago

  • Milestone changed from Future Release to 1.1

#11 in reply to: ↑ 8 @mr_pelle
15 years ago

Replying to GautamGupta:

Attached another patch which is ready to go into the core.

This should be committed, then. =)

#12 @GautamGupta
15 years ago

  • Milestone changed from 1.1 to Future Release

#14 @johnjamesjacoby
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

This was switched out to use bb_die. The tag moderation screens aren't beautiful, but they don't need to be since they are administrative functions. The bbPress plugin has this taken care of.

#15 @johnjamesjacoby
14 years ago

  • Milestone changed from Future Release to 1.1
  • Version 1.1-alpha deleted
Note: See TracTickets for help on using tickets.