XML-RPC array_merge warning

[timskii]

With pingback enabled, a PHP warning is logged:

array_merge() [function.array-merge]: Argument #1 is not an array in ..forums/xmlrpc.php on line 164

Part of BB_XMLRPC_Server() . Probably only an issue for PHP 5, which no longer accepts non-arrays in array_merge(). I assume $this->methods isn't supposed to be an array.

[Gautam Gupta]

Use typecasting to prevent error

[Gautam Gupta]

Attached the patch. It uses typecasting (as suggested here - ​http://php.net/manual/en/function.array-merge.php).

[chrishajer]

Where would I see this warning? I'd like to see it before I patch and see that it's resolved. Thanks

[GautamGupta]

Steps to reproduce:

---

1) Go to Settings -> Discussion and ensure that "Enable Pingbacks" is checked.
2) Go to Settings -> Writing and ensure that "XML-RPC" option is unchecked.
3) Go to yourforum.com/xmlrpc.php, and you should see an error like this:

Warning:  array_merge() [<a href='function.array-merge'>function.array-merge</a>]: Argument #1 is not an array in <b>/home/.../yourforum.com/xmlrpc.php</b> on line <b>164</b><br />

If you dont see the error (should not be the case, but still), then uncheck both the options and then check the "Enable Pingbacks" option.

[chrishajer]

OK, testing: enable pingbacks == true, XML-RPC == false. I do get this exact error. Will apply patch now and test again.

[chrishajer]

After apply patch, this is the result (as expected):

XML-RPC server accepts POST requests only. Will commit patch now. Thanks

[chrishajer]

(In [2410]) Cleanup array_merge PHP5 warning when pingbacks are enabled by typecasting array. Fixes #1214, props Gautam Gupta