Skip to:
Content

bbPress.org

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#1194 closed defect (bug) (fixed)

Extra slashes when deep integrating with WordPress

Reported by: mark-k Owned by:
Milestone: 1.0.3 Priority: normal
Severity: normal Version: 1.1-alpha
Component: General - Integration Keywords: has-patch
Cc: mark@…

Description

The reason is that bb-settings calls bb_global_sanitize regardless of the fact that the input was already sanitized by wordpress.

Suggested solution: put a "if ( !defined( 'ABSPATH' ) )" before the sanitizing calls.

Attachments (1)

1194.diff (935 bytes) - added by GautamGupta 11 years ago.
Untested but should work

Download all attachments as: .zip

Change History (11)

#1 @Gautam Gupta
12 years ago

  • Milestone set to 1.0.3

#2 @GautamGupta
12 years ago

  • Keywords needs-patch added

#3 @GautamGupta
12 years ago

  • Keywords reporter-feedback added; needs-patch removed
  • Resolution set to worksforme
  • Status changed from new to closed

Tried this on my install, there were no extra slashes. Does this still happen with the latest WordPress version too?

#4 @mark-k
12 years ago

Me bad, didn't gave enough details.

I was trying to write a bbpress as WP plugin. part of it was loading (as part of WP init) bb-settings which sanitize the input (this is from memory), but the input was already sanitized by WP..... This leads to double slashes.

As far as this report is concerned - I think that it is valid but since it seems to me right now that it is easier to use the new post_type types feature of WP 3.0 to make a simple forum for WP instead of deep integration, I'm no longer really interested in it.

#5 @GautamGupta
11 years ago

  • Keywords reporter-feedback removed
  • Resolution worksforme deleted
  • Status changed from closed to reopened

Reopened as more people are having the same issue - http://bbpress.org/forums/topic/when-i-use-apostrophe

@GautamGupta
11 years ago

Untested but should work

#6 @GautamGupta
11 years ago

Attached another patch which should fix the problem.

#7 @GautamGupta
11 years ago

  • Keywords has-patch needs-testing added
  • Summary changed from Extra slashes when deep integrating with wordpress to Extra slashes when deep integrating with WordPress

#8 @chrishajer
11 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [2448]) Attempt to fix "double slash" issue when deep integrating with WordPress 3.0 (only.) Fixes #1194. Props GautamGupta

#9 @mr_pelle
11 years ago

  • Version changed from 1.0.2 to 1.1-alpha

Still happens to me on bbPress 1.1-alpha-rev2461 + WP 2.9.2 (I just integrated header and footer adding require wp-load.php to bb-config.php), though it doesn't on bbPress 1.0.2 + WP 3.0, neither on bbPress 1.1-alpha-rev2461 + WP 3.0 (in this last case [2448] works perfectly).

Should I just upgrade to WP 3.0?

#10 @GautamGupta
11 years ago

  • Keywords needs-testing removed

That fix was only for WP 3.0 as Chris mentioned in the commit.

Note: See TracTickets for help on using tickets.