Skip to:
Content

bbPress.org

Opened 15 years ago

Last modified 13 years ago

#1183 new defect (bug)

function bb_latest_topics_pages doesn't obey $bb_db_override

Reported by: _ck_'s profile _ck_ Owned by:
Milestone: Future Release (Legacy) Priority: normal
Severity: normal Version:
Component: Back-end Keywords: has-patch blessed
Cc:

Description

When $bb_db_override is true, function bb_latest_topics_pages calculated the topic pages on it's own anyway, with it's own query, that doesn't even obey filters.

I propose when override is in effect, it looks at the old 0.9 bbpress global value $total which holds the total count.

(it's a huge waste in the first place to be re-doing that query when it's already calculated in the main query for the latest-discussions call. You aren't even obeying any filters that are active)

Attachments (1)

1183.diff​ (1.1 KB) - added by mr_pelle 14 years ago.
just added a $bb_db_override check

Download all attachments as: .zip

Change History (10)

#1 @Gautam Gupta
15 years ago

  • Milestone set to 1.0.3

#2 @GautamGupta
15 years ago

  • Keywords needs-patch added

#3 @GautamGupta
15 years ago

  • Milestone changed from 1.0.3 to 1.1

#4 @kevinjohngallagher
14 years ago

  • Milestone changed from 1.1 to 1.5

#5 @kevinjohngallagher
14 years ago

  • Milestone changed from Future Release to 1.1

@mr_pelle
14 years ago

just added a $bb_db_override check

#6 @mr_pelle
14 years ago

  • Keywords has-patch tested added; needs-patch removed

Don't know if I understood exactly the need: I just added a $bb_db_override check...

#7 @GautamGupta
14 years ago

  • Milestone changed from 1.1 to Future Release

#8 @johnjamesjacoby
14 years ago

  • Keywords blessed added; tested removed
  • Milestone changed from Future Release to 1.1
  • Version 1.0.2 deleted

Looks good for 1.1.

#9 @johnjamesjacoby
13 years ago

  • Keywords changed from has-patch, blessed to has-patch blessed
  • Milestone changed from 1.1 to 1.2
Note: See TracTickets for help on using tickets.