permalink decoding in 1.0 has absolutely no backwards compatibility

[_ck_]

Under 0.9, if a user upgraded to pretty permalinks, any external links from other sites into the forum would still work.

ie.
site.com/topic.php?id=2
site.com/profile.php?id=2
site.com/forum.php?id=2

would still work even if the new default was
ie.
site.com/topic/blah-blah

even this would work
ie.
site.com/topic/2
site.com/profile/2

if the full stub was specified, it would test for id # if the lookup by name failed.

But under 1.0, all attempts to determine if the old style is being passed are not done. So if someone has hundreds of inbound links out there, they will immediately stop working if the user changes to any other kind of permalink.

This is a serious degradation in behavior.

[sambauers]

These all work.

http://bbpress.org/forums/topic/cant-get-install-working
http://bbpress.org/forums/topic/50
http://bbpress.org/forums/topic.php?id=50

Was there a more specific case where it was broken?

[_ck_]

Oh that's weird it's working there.
It's not working on my trunk copy for some reason.
And other people have complained about it in some of my plugins.

Let me investigate more, and I'll try in safe-mode.

[_ck_]

Nope, still not working here.

I have 1.0 branch at revision 2362, in safe-mode, no plugins running.

permalinks set to "name based"

/profile/_ck_ WORKS
/profile/1 DOES NOT WORK (results in bb_die "User not found.")
/profile.php?id=1 DOES NOT WORK (results in bb_die "User not found.")

Let me switch to trunk and try again.

[_ck_]

Same bad results with trunk, will roll back to 1.0.2 release.

[_ck_]

Same results with 1.0.2 release.

Will test a little later on another server with different configuration.

But I know it's broken as I have tried it on some other servers run by other users.

It's possible nginx (or litespeed) on Automattic servers is emulating multiviews?

[_ck_]

Definitely a bug, fails on fresh install into apache.

Checkout trunk into a copy of xampp (apache 2 + php 5.2)

Switch to named based permalinks.

Confirm permalinks are working and htaccess was written.

Then tested /profile/1 and /profile.php?id=1 and both fail with bb_die

[_ck_]

Note that it also fails on a server running linux + litespeed + php 4

So completely different environments and same failure, not just a windows problem.

I suspect there is something on bbpress.org that is helping it somehow?

[_ck_]

Does not work:

http://bbpress.org/forums/profile/93934

http://bbpress.org/forums/profile.php?id=93934

(that number is me, funny I am under 100k, they are on 4 million now :-)

[_ck_]

Oh sorry, TOPICS and FORUMS work fine for backward compatibility, profiles do NOT.

0.9 handled the profile backward compatibility fine, 1.0 does not.

Wow I went crazy on this thread, sorry about that.

[sambauers]

Replying to _ck_:

Wow I went crazy on this thread, sorry about that.

That's OK, you've done a lot of good testing work here.

I'll look into why profiles are failing.

[sambauers]

(In [2364]) Try getting the user by both username and ID when fetching profiles. Fixes #1179