Skip to:
Content

Opened 5 years ago

Closed 5 years ago

#1136 closed defect (fixed)

"/wp-admin" never set. Gets skipped for mu, Integration fails for SSL.

Reported by: Jason_Jm Owned by: Jason_Jm
Milestone: 1.1 Priority: normal
Severity: normal Version: 1.0
Component: Integration Keywords: Integration
Cc:

Description

Creation of '/wp-admin' path'd cookie gets skipped with default install due to missing or null 'wp_admin_cookie_path' from install.

Quick Patch: Add the line below in your bb-config.php
$bb->wp_admin_cookie_path='/wp-admin';

OR core patch bb-settings.php (file attached).

Required for proper access when SSL is used.

(Note: SSL Requires patched wordpressmu 2.7.1: see http://trac.mu.wordpress.org/ticket/1014, and patched integration plugin: see http://bbpress.org/forums/topic/bbpress-10-released/page/3)

Attachments (3)

bb_settings_patch_bbpress_1_0.patch (919 bytes) - added by Jason_Jm 5 years ago.
UTF8 Patch File.
bb_settings_patch_bbpress_1_0_v2.patch (949 bytes) - added by Jason_Jm 5 years ago.
V2 Patch
bb_settings_patch_bbpress_1_0_v3.patch (1.1 KB) - added by Jason_Jm 5 years ago.
V3 Patch. Refactored and pretty.

Download all attachments as: .zip

Change History (17)

Jason_Jm5 years ago

UTF8 Patch File.

comment:1 Jason_Jm5 years ago

  • Milestone changed from 1.0.1 to 1.5

comment:2 Jason_Jm5 years ago

  • Milestone changed from 1.5 to 1.0.1

comment:3 sambauers5 years ago

I can think of three different setups for WPMU that may react differently to this change:

  1. Blogs as sub-domains ( http://XXXXXX.example.org )
  2. Blogs as sub-directories of the webserver root ( http://example.org/XXXXXX )
  3. Blogs as sub-directories of some other directory on the webserver ( http://example.org/some/path/XXXXXX )

We need to make sure these changes work in all three cases.

comment:4 Jason_Jm5 years ago

I'll get some unit tests up and running and define the cases.

You are right, that especially subdirectory installs this will break.

comment:5 Jason_Jm5 years ago

The cookie domain is being handled correctly so sub domains are ok.

As for subdirectories the updated v2 patch I'm attaching *should* handle that. Anyone else care to test? I'm not thee perfect coder thats for sure!

Subdirectories will use sitecookiepath as that will be good enough I think...

The root case (for people with blogs at the root) the patch address that issue by specifically looking for "/" for sitecookiepath. In this case you only want the "/wp-admin".

This was tested with mock data on a dev machine, not on a live dev system pulling all options from the db.

(look for v2 patch)

Jason_Jm5 years ago

V3 Patch. Refactored and pretty.

comment:6 Jason_Jm5 years ago

V3 Patch uploaded. Refactored and pretty.

comment:7 gogoplata5 years ago

I'm running WPMU 2.8.1 in a subdomain alongside bbPress 1.0.1 and experienced this issue, but was able to work around it by NOT defining " WordPress MU primary blog ID" on the WP integration options page.

comment:8 Jason_Jm5 years ago

Then your tables look like: wp_table instead of wp_#_table where # is the primary blog id.

Our tables look like wp_#_ as we have multiple blogs.

  • Jason Giedymin

comment:9 sambauers5 years ago

  • Milestone changed from 1.0.1 to 1.1

comment:10 sambauers5 years ago

  • Milestone changed from 1.1 to 1.0.3

comment:11 Jason_Jm5 years ago

Any idea about the changes to the integration plugin? Not quite sure where else to post it other than http://bbpress.org/forums/topic/bbpress-10-released/page/3 ::shugs::

comment:12 Jason_JM5 years ago

  • Keywords Integration added
  • Milestone changed from 1.0.3 to 1.1
  • Owner set to sambauers

Was this integrated?

  • Jason Giedymin, AcronymLabs.com

comment:13 Jason_Jm5 years ago

  • Owner changed from sambauers to Jason_Jm

comment:14 Jason_Jm5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I see this in trunk now.

Note: See TracTickets for help on using tickets.