Skip to:
Content

Opened 2 months ago

Closed 2 months ago

#3235 closed defect (fixed)

admin area update puts a subscription on a revision post (RC7)

Reported by: wpturk Owned by: johnjamesjacoby
Milestone: 2.6 Priority: high
Severity: normal Version: trunk
Component: API - Engagements Keywords: needs-patch
Cc:

Description

I am running the latest 2.6 RC7 and discovered problem regarding subscriptions:

This is before updating topic (post_id:54878) in admin area:

mysql> select * from forum_postmeta where meta_key="_bbp_subscription" ; 
+---------+---------+-------------------+------------+
| meta_id | post_id | meta_key          | meta_value |
+---------+---------+-------------------+------------+
.....
.....
|   35265 |   54878 | _bbp_subscription | 11743      |
+---------+---------+-------------------+------------+

This is after updating the topic (post_id:54878) in admin area:

mysql> select * from forum_postmeta where meta_key="_bbp_subscription" ; 
+---------+---------+-------------------+------------+
| meta_id | post_id | meta_key          | meta_value |
+---------+---------+-------------------+------------+
.....
.....
|   35265 |   54878 | _bbp_subscription | 11743      |
|   35280 |   54879 | _bbp_subscription | 1          |
+---------+---------+-------------------+------------+

admin save puts a subscription on a revision post (54879). I think this should be corrected.

Change History (3)

#1 @johnjamesjacoby
2 months ago

  • Component changed from General to API - Engagements
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 2.6
  • Owner set to johnjamesjacoby
  • Version set to trunk

#2 @johnjamesjacoby
2 months ago

This bug was introduced in r6811, as part of #3185.

Working on a fix now.

#3 @johnjamesjacoby
2 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In 6886:

Subscriptions: Do not add or remove subscriptions when editing via WordPress admin.

This change passes the current post ID through to bbp_is_user_subscribed(), ensuring that admin area subscriptions are saved to the correct topic ID (not revisions, etc...) while also not changing the subscriptions status.

Fixes #3235.

Note: See TracTickets for help on using tickets.