Skip to:
Content

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#3215 closed defect (fixed)

Remove whitelist/blacklist references

Reported by: johnjamesjacoby Owned by: johnjamesjacoby
Milestone: 2.6 Priority: high
Severity: normal Version: 2.0
Component: API - Moderation Keywords: has-patch commit
Cc:

Description

The moderation API contains several references to the blacklist_keys WordPress option, going as far as naming functions after it. While this is not an uncommon practice, it is unintentionally maintaining an unhealthy, unwelcome, and historically hostile status quo.

To make bbPress as welcoming and inclusive as possible to all audiences, let's deprecate uses of "blacklist" and "whitelist".

Patch & commit incoming.

Attachments (1)

3215.patch (19.6 KB) - added by johnjamesjacoby 6 months ago.

Download all attachments as: .zip

Change History (4)

#1 @johnjamesjacoby
6 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 6855:

Moderation: remove references to blacklist/whitelist verbiage.

This change combines 2 functions into 1, merging _blacklist() checks into _moderation() checks. A new $strict parameter is added, when set to true will continue to check against the WordPress blacklist_keys option name.

  • Tests updated
  • bbp_check_for_blacklist() deprecated
  • Error response keys renamed (non breaking - nothing relies on them)
  • Some docs updates

Fixes #3215. For 2.6.

#2 @johnjamesjacoby
6 months ago

In 6857:

Moderation: allow custom keys to be passed in via the $strict parameter.

See #3215.

#3 @johnjamesjacoby
6 months ago

In 6858:

Moderation: add author-specific keymaster & moderation checks.

This fixes a regression where Moderators were allowed to skip strict moderation rules. Moderators are held to the same standard that regular users in the forums are.

See #3215.

Note: See TracTickets for help on using tickets.