Skip to:
Content

Opened 7 months ago

Closed 7 months ago

#3213 closed defect (fixed)

Incorrect value passed for new reply notification in buddypress

Reported by: seennothurd Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5
Component: Extend - BuddyPress Keywords: commit
Cc:

Description

The value passed into the item_id key of the array of args for bp_notifications_add_notification (includes/extend/buddypress/notifications.php:149) does not match the value expected for the notification formatting (includes/extend/buddypress/notifications.php:70).

The value the formatting function expects is the reply ID. The value passed along from the bp_notifications_add_notification function is the topic ID of that reply. This means the bbp_get_reply_url function returns a useless url, which in the case of Buddypress causes an redirect loop.

This means users cannot get to the new reply as notified.

Change History (2)

#1 @johnjamesjacoby
7 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.6
  • Owner set to johnjamesjacoby
  • Version changed from trunk to 2.5

#2 @johnjamesjacoby
7 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In 6845:

BuddyPress: use $reply_id instead of $topic_id so bbp_get_reply_url() works correctly.

This change ensures that notification links go directly to the reply, not the topic, and not a 404.

Fixes #3213. See #3214.

Note: See TracTickets for help on using tickets.