Skip to:
Content

bbPress.org

Opened 2 years ago

Closed 17 months ago

#3150 closed defect (fixed)

Fix "Undefined index: salt" notice during phpBB user import

Reported by: jrf Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: trunk
Component: API - Importers Keywords: has-patch 2nd-opinion needs-testing
Cc: johnjamesjacoby, jrf

Description

When running a user import from phpBB, the error log is being flooded with PHP error notices:

PHP Notice:  Undefined index: salt in path/to/wp-content/plugins/bbpress/includes/admin/converters/phpBB.php on line 719

I imagine that this error will also impact the password conversion and potentially cause other issues, but I haven't tested that far yet.

The patch attached now uses the field name as defined in line 531: https://bbpress.trac.wordpress.org/browser/trunk/src/includes/admin/converters/phpBB.php#L531

A second opinion on this fix would be much appreciated as I haven't dug in deep into the code to verify if this is the best way to fix this.

Attachments (1)

trac-3150-fix-password-salt.patch (668 bytes) - added by jrf 2 years ago.

Download all attachments as: .zip

Change History (3)

#1 @johnjamesjacoby
17 months ago

  • Milestone changed from Awaiting Review to 2.6
  • Owner set to johnjamesjacoby

#2 @johnjamesjacoby
17 months ago

  • Resolution set to fixed
  • Status changed from new to closed

This was fixed in r6809.

Note: See TracTickets for help on using tickets.