Skip to:
Content

Opened 2 years ago

Closed 2 years ago

#3079 closed defect (fixed)

Found a typo in bbpress.php file

Reported by: alexvorn2 Owned by: netweb
Milestone: 2.5.13 Priority: normal
Severity: normal Version: 2.1
Component: API - Actions/Filters Keywords: needs-patch
Cc:

Description

Line 200:

$this->basename   = apply_filters( 'bbp_plugin_basenname', plugin_basename( $this->file ) );

Should be:

$this->basename   = apply_filters( 'bbp_plugin_basename', plugin_basename( $this->file ) );

BTW: $this->basename returns bbpress/bbpress.php

Is this correct? Should it return only bbpress ?

Change History (2)

#1 in reply to: ↑ description @netweb
2 years ago

  • Component changed from General to API - Actions/Filters
  • Milestone changed from Awaiting Review to 2.5.13
  • Version changed from trunk to 2.1

Thanks Alex, good spotting, we previously fixed this for the 2.6 /trunk branch in r5316 but I'm going to go ahead and backport this commit for the 2.5 branch.

Replying to alexvorn2:

BTW: $this->basename returns bbpress/bbpress.php

Is this correct? Should it return only bbpress ?

Yes it is correct, basename includes the path, see https://codex.wordpress.org/Function_Reference/plugin_basename

#2 @netweb
2 years ago

  • Owner set to netweb
  • Resolution set to fixed
  • Status changed from new to closed

In 6364:

Fix basename filter in bbPress:setup_globals().

This changeset if for /branches/2.5, previously [5316] for /trunk

Props alexvorn2.
Fixes #3079.

Note: See TracTickets for help on using tickets.