Skip to:

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#3065 closed defect (fixed)

Deleting a subscription should leave one on the same page

Reported by: sterndata Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.0
Component: API - Subscriptions Keywords: needs-patch


I have 345 pages of topic subscriptions at I thought I'd clean that up, so i went to page 345 and thought I can just X my way through during dull moments of the day. But when I click on any of the Xs, it takes me back to page 1.

Change History (7)

This ticket was mentioned in Slack in #forums by sterndata. View the logs.

2 years ago

#2 @johnjamesjacoby
2 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 2.6
  • Version set to 2.0

That's annoying. Sorry about that. You're totally right.

Should be an easy fix. Thanks for letting us know.

#3 @johnjamesjacoby
2 years ago

In 6305:

Favorites/Subscriptions: Look for a redirect_to destination in handlers.

See #3065.

#4 @johnjamesjacoby
2 years ago

In 6307:

Favorites/Subscriptions: Add redirect_to parameters to links if viewing relevant user profile pages.

See #3065.

#5 @johnjamesjacoby
2 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 6308:

Favorites/Subscriptions: Add paged data to permalinks when in the loop.

Also addredirect_to parameters to links if passed in.

Fixes #3065.

#6 @johnjamesjacoby
2 years ago

In 6309:

Favorites/Subscriptions: Pagination & redirect_to clean-up.

  • PHPDoc & inline doc
  • Prefer urlencode() over esc_url() for redirect_to query argument
  • Corrections to forum & topic subscription loop logic, since they're both listed on the same page

See #3065.

#7 @johnjamesjacoby
2 years ago

So, this is fixed, but there is a known issue that will take too long for us to fix in the 2.6 cycle.

Basically put, if you try to visit a page that doesn't exist, bbPress will 404 rather than redirect to the closest available page. If clicking the x on a single item on page 3, it won't know to redirect to page 2.

The same thing happens in WordPress, and basically every other paginated request, so I'm comfortable calling this fixed until we can come up with a solution with wider coverage.

Last edited 2 years ago by johnjamesjacoby (previous) (diff)
Note: See TracTickets for help on using tickets.