Skip to:
Content

bbPress.org

Opened 3 years ago

Closed 3 years ago

#3036 closed defect (fixed)

Compare against $component_action_name instead of $action in bbp_format_buddypress_notifications()

Reported by: tw2113 Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.1
Component: Extend - BuddyPress Keywords: needs-patch reporter-feedback
Cc:

Description

In BuddyPress 2.6.0 the core devs added $component_action_name, $component_name, $id as parameters to the bp_notifications_get_notifications_for_user filter and recommend comparing against $component_action_name instead of the original $action with regards on if a callback should act or not.

Current version still compares against $action

Change History (4)

#1 @johnjamesjacoby
3 years ago

  • Component changed from General to Extend - BuddyPress
  • Keywords reporter-feedback added
  • Milestone changed from Awaiting Review to 2.6
  • Version set to 2.1

I see component_name and component_action but not component_action_name.

This ticket was mentioned in Slack in #buddypress by jjj. View the logs.


3 years ago

This ticket was mentioned in Slack in #bbpress by jjj. View the logs.


3 years ago

#4 @johnjamesjacoby
3 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 6262:

BuddyPress: Update bbp_format_buddypress_notifications() with new parameters.

  • Prefer $component_action_name over less reliable $content
  • Parameters match BuddyPress 2.6.0 and higher signature
  • Mild function clean-up

Fixes #3036.

Note: See TracTickets for help on using tickets.