Skip to:
Content

bbPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2983 closed defect (fixed)

The default single user slug `bbp_get_user_slug()` is `users`, not `user`

Reported by: netweb Owned by: netweb
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: API - Settings/Options Keywords: has-patch
Cc:

Description (last modified by netweb)

The default value of bbp_get_user_slug() should be users, not user, see src/includes/core/options.php#L615

The bbp_get_default_options() function defines the default as users, see src/includes/core/options.php#L82

In a scenario where bbPress options have not been saved as happened recently with the international forums rollout this will cause the single user slug to be user and not users. Resaving bbPress' options restores users as the single user slug.

Edit: Originally reported in #meta1868 #18

Attachments (1)

2983.diff (477 bytes) - added by netweb 3 years ago.

Download all attachments as: .zip

Change History (4)

@netweb
3 years ago

#1 @netweb
3 years ago

  • Owner set to netweb
  • Resolution set to fixed
  • Status changed from new to closed

In 6078:

Options: Set the default value of bbp_get_user_slug() to users

This changeset updates the default single user slug from user to users. The bbp_get_default_options() function defines the default as users and this is used when installing and activating bbPress. This fixes a scenario where bbPress options have not been saved which would cause the single user slug to use the unexpected slug user rather than users.

Props ocean90.
Fixes #2983

#2 @netweb
3 years ago

  • Description modified (diff)

#3 @netweb
3 years ago

In 6080:

Tests: Following r6078 update tests in ::BBP_Tests_Users_Template_User to use single user slug users

See #2983

Note: See TracTickets for help on using tickets.