Skip to:
Content

Opened 3 years ago

Closed 3 years ago

#2914 closed enhancement (fixed)

Add support for uploading patches to trac with grunt task `grunt patch`

Reported by: netweb Owned by: netweb
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: Tools - Build Keywords: has-patch commit
Cc:

Description

The upcoming 0.4.0 release of grunt-patch-wordpress will support uploading patches to Trac.

For example: grunt upload_patch:98765 will upload a diff/patch of the current directory to ticket #98765

The attached patch is just for the new Grunt task grunt upload_patch:xxxx where xxxx is the ticket number, before committing this both grunt-patch-wordpress version 0.4.0 needs to be released and a subsequent ticket created to first update bbPress to use grunt-patch-wordpress

Attachments (3)

2914.diff (370 bytes) - added by netweb 3 years ago.
2914.2.diff (813 bytes) - added by jorbin 3 years ago.
2914.3.diff (813 bytes) - added by netweb 3 years ago.

Download all attachments as: .zip

Change History (10)

@netweb
3 years ago

#1 @netweb
3 years ago

  • Keywords has-patch added

The patch 2914.diff was actually uploaded as part of the testing of the pre-release version 0.4.0 of grunt-patch-wordpress using the following: grunt upload_patch:2914

#3 @netweb
3 years ago

  • Owner set to netweb
  • Status changed from new to assigned

@jorbin
3 years ago

#4 follow-up: @jorbin
3 years ago

0.4.0 is no available. Note that not all users have the xmpl-rpc privlages. I get the following error:
Warning: Something went wrong when attempting to upload the patch. Please confirm your credentials and the ticket number. Error: XML-RPC fault: XML_RPC privileges are required to perform this operation. You don't have the required permissions.

@netweb
3 years ago

#5 in reply to: ↑ 4 @netweb
3 years ago

Replying to jorbin:

0.4.0 is no available. Note that not all users have the xmpl-rpc privlages. I get the following error:
Warning: Something went wrong when attempting to upload the patch. Please confirm your credentials and the ticket number. Error: XML-RPC fault: XML_RPC privileges are required to perform this operation. You don't have the required permissions.

Yeah, I thought it may have enabled for the "Gardeners" group here also like as it is for WordPress Trac.

:boom: I uploaded 2914.3.diff using grunt upload_patch:2914 as I have XML-RPC permissions here :)

Committed to WordPress core via https://core.trac.wordpress.org/changeset/37612

#6 @netweb
3 years ago

  • Keywords commit added
  • Milestone changed from Under Consideration to 2.6

Adding a copy of the #core commit message:


Update grunt-patch-wordpress to 0.4.0

This update adds two main features for your WordPress development happiness.

1) GitHub URL support. You can now use grunt patch:https://github.com/aaronjorbin/develop.wordpress/pull/3 with any copy of WordPress on GitHub. No longer will you need to download the patch manually. Works for both core and develop mirrors on GitHub.

2) Upload patches directly from the command line. No longer will you need to create a patch and manually upload it to trac. grunt upload_patch:20000 will upload a patch to the appropriate ticket after a user enters a WordPress.org username and password. This is limited to users with the appropriate XML-RPC privileges in trac (right now, that is just bug gardeners). You still need to manually add the has patch keyword.

Full changelog: https://github.com/aaronjorbin/grunt-patch-wordpress/compare/0.3.0...0.4.0

#7 @netweb
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 6049:

Update grunt-patch-wordpress to 0.4.0

This update adds two main features for your WordPress development happiness.

1) GitHub URL support. You can now use grunt patch:https://github.com/bbpress/bbPress/pull/3 with any copy of bbPress on GitHub. No longer will you need to download the patch manually.

2) Upload patches directly from the command line. No longer will you need to create a patch and manually upload it to trac. grunt upload_patch:20000 will upload a patch to the appropriate ticket after a user enters a WordPress.org username and password. This is limited to users with the appropriate XML-RPC privileges in trac (right now, that is just bug committers). You still need to manually add the has patch keyword.

Full changelog: https://github.com/aaronjorbin/grunt-patch-wordpress/compare/0.3.0...0.4.0

Props jorbin, ericlewis, michaelbeil, netweb
Fixes #2914.

Note: See TracTickets for help on using tickets.