Skip to:
Content

Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#2906 closed defect (fixed)

Bulk change forum role no longer working

Reported by: casiepa Owned by: netweb
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5.8
Component: General - Administration Keywords: has-patch
Cc:

Description

WP 4.4.1
Selecting 1 or more users, in the dropdown box 'Change forum role to...' choose e.g. participant, click change.
Screen refreshes but nothing is changed.

Reported here: https://bbpress.org/forums/topic/how-to-import-bbpress-users/#post-170887
Tested myself and I have the same issue.

Attachments (3)

2906.patch (1.0 KB) - added by ocean90 3 years ago.
WP < 4.6
2906.2.patch (3.2 KB) - added by ocean90 3 years ago.
WP >= 4.6
2906.diff (4.5 KB) - added by netweb 3 years ago.

Download all attachments as: .zip

Change History (11)

This ticket was mentioned in Slack in #bbpress by casiepa. View the logs.


3 years ago

#2 @netweb
3 years ago

  • Component changed from General to General - Administration
  • Milestone changed from Awaiting Review to Under Consideration

I think this is a regression introduced as part of #WP22959

To test, I'd take a look at commits from that upstream ticket and see if anything stands out, if the commit is easily reverted in a test setup that might also be a helpful way to test.

#3 @ocean90
3 years ago

That's because the dropdown exists at the bottom too which replaces the values from the top on submit.

Related: #WP35307

@ocean90
3 years ago

WP < 4.6

@ocean90
3 years ago

WP >= 4.6

#5 @ocean90
3 years ago

  • Keywords has-patch added

@netweb
3 years ago

#6 @netweb
3 years ago

  • Milestone changed from Under Consideration to 2.6

Thanks @ocean90, 2906.diff merges 2906.patch and 2906.2.patch around some if/else WordPress 4.6 checks.

Got to watch for this grunt upload_patch:2906 task filenames, it always uses the .diff extension...

#7 @netweb
3 years ago

  • Owner set to netweb
  • Resolution set to fixed
  • Status changed from new to closed

In 6061:

General - Administration: Update "change forum role" dropdown

This changeset resolves an issue introduced in WordPress 4.4 ( changeset:34636 / #WP27743 ) which caused bbPress "change forum role" dropdown to only work using the "bottom" user list table dropdown, for WordPress versions < 4.6 the "change forum role" dropdown is now only shown at the "top" of the user list table.

This changeset also adds a new parameter $which to user_role_bulk_dropdown() which was added in WordPress 4.6 ( changeset:37422 / #WP35307 ) to pass the location of the extra table nav markup for the "top" or "bottom" "change role" dropdown, and in turn fixes bbPress' "change forum role" dropdown to once again work at the "top" and "bottom" of the user list table.

Props ocean90.
Fixes #2906.

#8 @netweb
2 years ago

#3045 was marked as a duplicate

Note: See TracTickets for help on using tickets.