Skip to:
Content

bbPress.org

Opened 4 years ago

Closed 3 years ago

#2881 closed defect (fixed)

Avoid using HTML tags in translation strings

Reported by: ramiy Owned by: netweb
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: Locale - i18n/l10n Keywords: has-patch commit has-screenshots
Cc:

Description

In the next version of WordPress (4.4), we fixed many translation strings that used HTML tags, removing the HTML tags out from the strings.

The same thing done in BuddyPress 2.4.

In this ticket I will try to do the same for bbPress. See the attached patches.

Attachments (6)

2881-admin.php.patch (802 bytes) - added by ramiy 4 years ago.
move <em> tags out of the string
2881-strong.patch (3.4 KB) - added by ramiy 4 years ago.
move <strong> tags out of the string
strings.png (98.1 KB) - added by ramiy 4 years ago.
The HTML tags that can be moved out of the strings
2881.03.patch (4.4 KB) - added by thebrandonallen 4 years ago.
2881.04.patch (4.2 KB) - added by ramiy 4 years ago.
2881.05.patch (4.3 KB) - added by thebrandonallen 3 years ago.

Download all attachments as: .zip

Change History (13)

@ramiy
4 years ago

move <em> tags out of the string

@ramiy
4 years ago

move <strong> tags out of the string

@ramiy
4 years ago

The HTML tags that can be moved out of the strings

#1 follow-up: @thebrandonallen
4 years ago

  • Keywords commit has-screenshots added
  • Milestone changed from Awaiting Review to 2.6

Thanks for these as well! Added 2881.03.patch to condense patches into one. Fixes issues with 2881-strong.patch where the <strong> tags were added to the wrong string, and some code formatting issues.

#2 in reply to: ↑ 1 @ramiy
4 years ago

Replying to thebrandonallen:

Thanks for these as well! Added 2881.03.patch to condense patches into one. Fixes issues with 2881-strong.patch where the <strong> tags were added to the wrong string, and some code formatting issues.

Thanks for fixing the patch.

I have just one request, it seems like the sprintf() function has 3 parameters (is has only two).

We need to set the date_i18n() function with it's parameters in one line. This way, the code wont be confusing.

@ramiy
4 years ago

#3 @ramiy
4 years ago

Related: #2910

#4 @ramiy
4 years ago

Related: #2911

#5 @ramiy
4 years ago

Related: #2912

#6 @thebrandonallen
3 years ago

Updated patch to allow it to apply cleanly against trunk, and further reduces HTML usage in strings.

#7 @netweb
3 years ago

  • Owner set to netweb
  • Resolution set to fixed
  • Status changed from new to closed

In 6042:

i18n: Avoid using HTML tags in translation strings

Props ramiy, thebrandonallen
Fixes #2881

Note: See TracTickets for help on using tickets.