Skip to:
Content

Opened 3 years ago

Closed 3 years ago

#2877 closed defect (fixed)

broken dependency in bbpress-functions when enqueuing user.js

Reported by: tharsheblows Owned by: netweb
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5
Component: Component - Users Keywords: has-patch
Cc:

Description

In bbpress-functions.php in the default template, I'm getting a broken dependency warning when user.js is enqueued -- it's trying to get user-query which doesn't seem to be registered.

It's a typo, I think, and introduced here [5183] (line 209). You can see the original version [5172] (line 209) doesn't have any dependencies and it doesn't look like it needs anything, user.js is just a few lines long.

Attachments (1)

2877.diff (484 bytes) - added by tharsheblows 3 years ago.
remover user-query dependence from js/user.js

Download all attachments as: .zip

Change History (3)

@tharsheblows
3 years ago

remover user-query dependence from js/user.js

#1 @thebrandonallen
3 years ago

  • Keywords dev-feedback removed
  • Milestone changed from Awaiting Review to 2.6
  • Version set to 2.5

This means that user.js hasn't been loaded for the entirety of 2.5. Great find!

#2 @netweb
3 years ago

  • Owner set to netweb
  • Resolution set to fixed
  • Status changed from new to closed

In 5949:

Users: In BBP_Default::enqueue_scripts remove rogue script dependency for single user edits

This changeset removes the user-query dependency that was accidentally introduced in r5183

Props tharsheblows
Fixes #2877

Note: See TracTickets for help on using tickets.