Skip to:
Content

Opened 4 years ago

Closed 2 years ago

Last modified 4 weeks ago

#2841 closed enhancement (fixed)

Update "Repair Tools" screen to use a list table

Reported by: johnjamesjacoby Owned by:
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.1
Component: Tools Keywords: commit
Cc:

Description

The "Repair Tools" screen is getting difficult to navigate with so many tools in there. Why don't we bring it up to speed with all that WordPress has to offer.

  • Search
  • Filters
  • Columns & rows
  • Bulk actions
  • Single action links

Steps:

  • Converting our existing UI
  • Convert to WP_List_Table
  • Move feedback messages into tools vs. callback repair methods

Attachments (3)

Screen Shot 2015-08-06 at 1.28.53 PM.png (128.0 KB) - added by johnjamesjacoby 4 years ago.
2841.1.diff (904 bytes) - added by tharsheblows 4 years ago.
add in id to run links
2841.2.diff (1.0 KB) - added by tharsheblows 4 years ago.
add data-nonce attr to run links

Download all attachments as: .zip

Change History (15)

#1 follow-up: @johnjamesjacoby
4 years ago

In 5885:

Tools: Update "Repair Tools" to use a list-table UI:

  • Includes helper functions for: search, filtering, and bulk actions
  • Improves tool registration by including strings and feedback into an array stored in bbpress()->admin->tools
  • Introduces "Overhead" property for alerting Key Masters to the performance impact running each tool
  • Introduces "Components" properties for identifying which counts what tools are intersecting
  • Todo: use a WP_List_Table subclass (which bbPress has avoided needing until now)

See #2841.

#2 @johnjamesjacoby
4 years ago

Now would be a good time to add a "Last Ran" column and save a timestamp in the options table for each test. Would be interesting to see when each repair tool was used last. Could also keep a counter for each one too. Hmmmm.

#3 @netweb
4 years ago

Related: #2731

#4 @tharsheblows
4 years ago

Can we add an id to the run links? At least for now so I can test the menu_order thing.

@tharsheblows
4 years ago

add in id to run links

#5 @tharsheblows
4 years ago

I like the way it looks! I mean the table, not the a ids.

#6 @johnjamesjacoby
4 years ago

In 5892:

Tools: Add id attribute to "Run" link. Props tharsheblows. See #2841.

#7 @tharsheblows
4 years ago

Also can we add a data-nonce attribute to the links with an indiv nonce? That way they're right there for ease of use.

@tharsheblows
4 years ago

add data-nonce attr to run links

#8 @johnjamesjacoby
4 years ago

In 5899:

Tools: Use _admin_search_query(). See #2841.

#9 @netweb
3 years ago

Related: #2859 Reply topic id tool doesn't show

#10 in reply to: ↑ 1 @netweb
3 years ago

Replying to johnjamesjacoby:

Todo: use a WP_List_Table subclass (which bbPress has avoided needing until now)

Replying to johnjamesjacoby:

Now would be a good time to add a "Last Ran" column and save a timestamp in the options table for each test. Would be interesting to see when each repair tool was used last. Could also keep a counter for each one too. Hmmmm.

Replying to tharsheblows:

Also can we add a data-nonce attribute to the links with an indiv nonce? That way they're right there for ease of use.

The above 3 items appear to be outstanding for this ticket @johnjamesjacoby Do you want to tackle these here for 2.6?

If not, we can move these to new tickets and mark this as fixed :)

#11 @johnjamesjacoby
2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Welp, I forgot I opened this ticket, and ended up doing this a few weeks ago for 2.6.

Marking as fixed. <3

#12 @johnjamesjacoby
4 weeks ago

Assigning all closed & unassigned tickets in the 2.6 milestone to myself.

Note: See TracTickets for help on using tickets.