Skip to:
Content

bbPress.org

Opened 4 years ago

Closed 3 years ago

#2794 closed enhancement (fixed)

Add BP dynamic activity actions

Reported by: thebrandonallen Owned by: johnjamesjacoby
Milestone: 2.6 Priority: high
Severity: normal Version: 2.2
Component: Extend - BuddyPress Keywords: has-patch
Cc:

Description

Included patch adds dynamic activity actions for site wide/group forums. Also includes fix for #2690 by @r-a-y.

Attachments (6)

2794.01.patch (5.4 KB) - added by thebrandonallen 4 years ago.
2794.02.patch (6.8 KB) - added by thebrandonallen 4 years ago.
2794.02.tests.patch (9.5 KB) - added by thebrandonallen 4 years ago.
2794.03.patch (6.8 KB) - added by netweb 3 years ago.
Refresh of 2794.02.patch against /trunk
2794.04.patch (6.4 KB) - added by thebrandonallen 3 years ago.
2794.05.patch (16.9 KB) - added by thebrandonallen 3 years ago.

Download all attachments as: .zip

Change History (19)

#1 @johnjamesjacoby
4 years ago

  • Keywords needs-testing needs-docs added
  • Owner set to johnjamesjacoby
  • Priority changed from normal to high

This ticket was mentioned in Slack in #bbpress by thebrandonallen. View the logs.


4 years ago

#3 @thebrandonallen
4 years ago

Updating patch and adding tests.

#4 @thebrandonallen
4 years ago

  • Keywords needs-testing needs-docs removed

@netweb
3 years ago

Refresh of 2794.02.patch against /trunk

#5 @thebrandonallen
3 years ago

One more refresh against trunk, plus some documentation improvements.

#6 @johnjamesjacoby
3 years ago

Patch isn't applying cleanly for me. A refresh would be helpful, or else I'll circle back to this during beta.

#7 @thebrandonallen
3 years ago

Patch updated for latest trunk.

#8 @johnjamesjacoby
3 years ago

For some reason, src/includes/extend/buddypress/activity.php still gets skipped.

I'll apply it manually and review that way.

#9 @johnjamesjacoby
3 years ago

The problem here is that BuddyPress doesn't support filtering of activity items by both component & action.

Because bbPress uses the same action for both group & site-wide forums, this results in duplicate items in the activity drop-down filters (both theme-side and admin-side.)

I'll modify this a bit, and we'll need to also modify BuddyPress if we want this to work differently upstream.

#10 @johnjamesjacoby
3 years ago

In 6370:

BuddyPress: Dynamic activity for topics & replies, part 1.

  • Functions for activity action filters

Props thebrandonallen. See #2794.

#11 @johnjamesjacoby
3 years ago

In 6372:

BuddyPress: Dynamic activity for topics & replies, part 2.

  • Filters for activity action functions
  • Tests for the new activity filters

Props thebrandonallen. See #2794.

This ticket was mentioned in Slack in #bbpress by netweb. View the logs.


3 years ago

#13 @johnjamesjacoby
3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Pretty sure this is as fixed as we can make it, without a change to BuddyPress.

Closing for the 2.6 milestone. Further enhancements or bugs should be new tickets.

Thanks everyone!

Note: See TracTickets for help on using tickets.