Skip to:
Content

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2780 closed defect (fixed)

Users cannot confirm/dismiss email address changes on multisite

Reported by: johnjamesjacoby Owned by: johnjamesjacoby
Milestone: 2.6 Priority: high
Severity: normal Version: 2.0
Component: Component - Users Keywords:
Cc:

Description

When porting the WordPress user profile and edit_user() code over, the multisite-only email-address confirmation bits were also ported, but incorrectly.

It looks like because bbp_edit_user_handler() is hooked to the bbp_post_request action, the $_GET conditions will never have the chance to happen.

BuddyPress has already ported this multisite-only functionality to be always-on, even for single-site installations, and I believe it is wise for bbPress to do the same because most users performing this action are "untrusted" community members vs. "trusted" members with full wp-admin access to directly manipulate user data, even if it is their own.

Change History (8)

#1 @johnjamesjacoby
4 years ago

Roadmap to repairing this for 2.6:

  • Clean up existing "Pending email change" messaging in templates
  • Move messaging into a template notice
  • Move $_GET checks into their own function, hooked to bbp_get_request
  • Port & customize multisite-only send_confirmation_on_profile_email() function

#2 @johnjamesjacoby
4 years ago

In 5660:

Users: Remove pending email change markup from form-user-edit.php. See #2780.

#3 @johnjamesjacoby
4 years ago

In 5661:

Users: Introduce bbp_notice_edit_user_email_change() to notify user of a pending email address change to their account. See #2780.

#4 @johnjamesjacoby
4 years ago

In 5662:

Users: Extract $_GET conditions out of bbp_edit_user_handler() and into their own function, hooked to bbp_get_request action.

This fixes functionality that was only half ported from edit_user() & WordPress multisite which allows a user to confirm or dismiss pending email address changes to their account from within their bbPress profile edit page.

See #2780.

#5 @johnjamesjacoby
4 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5663:

Users: Email address change improvements:

  • Introduce function for handling sending notification email
  • Clean up code required to update, save, confirm, & dismiss pending email address changes
  • Fixes bug in previous implementation making it impossible to interact with pending email address changes on multisite installations

Fixes #2780.

#6 @johnjamesjacoby
4 years ago

In 5664:

Users: Clean up email message string replacements in bbp_edit_user_email_send_notification(). See #2780.

#7 @johnjamesjacoby
4 years ago

In 5665:

Users: Update filter name in bbp_edit_user_email_send_notification() to be a bit more clear. See #2780.

#8 @johnjamesjacoby
4 years ago

In 5666:

Users: Add missing textdomains to new strings. See #2780.

Note: See TracTickets for help on using tickets.