Skip to:
Content

bbPress.org

Opened 4 years ago

Closed 4 years ago

#2779 closed defect (duplicate)

missing return statement in function bbp_format_buddypress_notifications

Reported by: jyd44 Owned by:
Milestone: Priority: normal
Severity: major Version: 2.2
Component: Extend - BuddyPress Keywords:
Cc:

Description

The function bbp_format_buddypress_notifications in includes/extend/buddypress is attached to the bp filter "bp_notifications_get_notifications_for_user".

This function has no return when the action is not equal to "bbp_new_reply". This break the chain during the call to the apply_filter function.

Just need to add at the end of the function the following line:
else return $action;

Change History (1)

#1 @johnjamesjacoby
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed
  • Version set to 2.2

Thanks for the ticket and taking the time to investigate a fix.

We've already fixed this in trunk as part of #2665 in r5512, so I'm marking this as a duplicate.

The fix will be part of the next major bbPress release, which will be 2.6.

Thanks again!

Note: See TracTickets for help on using tickets.