Skip to:
Content

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2718 closed defect (fixed)

`BBP_Forums_Group_Extension::display()` should take `$group_id` param

Reported by: boonebgorges Owned by: johnjamesjacoby
Milestone: 2.5.8 Priority: normal
Severity: normal Version: 2.0
Component: Extend - BuddyPress Keywords: has-patch
Cc:

Description

See https://buddypress.trac.wordpress.org/ticket/5533#comment:7. PHP notices will be thrown in strict mode if the class definition doesn't match the parent. (Sorry :) ) Patch attached.

Attachments (1)

2718.patch (681 bytes) - added by boonebgorges 4 years ago.

Download all attachments as: .zip

Change History (11)

@boonebgorges
4 years ago

#1 @boonebgorges
4 years ago

  • Keywords has-patch added

#2 @netweb
4 years ago

  • Milestone changed from Awaiting Review to 2.6
  • Owner set to johnjamesjacoby

Thanks Boone :)

#3 @johnjamesjacoby
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 5560:

Match up arguments with parent class method to avoid notices. Props boonebgorges. Fixes #2718.

This ticket was mentioned in Slack in #buddypress by boone. View the logs.


4 years ago

#5 follow-up: @danbp
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version set to 2.5.5

#6 in reply to: ↑ 5 @johnjamesjacoby
4 years ago

Replying to danbp:

Just to inform you that this patch is not in 2.5.5 !

https://bbpress.trac.wordpress.org/browser/tags/2.5.5/includes/extend/buddypress/groups.php#L151

Correct. This ticket is in the 2.6 milestone. Just like with BuddyPress & WordPress, x.x.x releases are reserved for relatively critical bug fixes to the x.x branch.

#7 @danbp
4 years ago

Thank you @jjj, but sorry to come back to tell that the notice is still there after patching.

WP 4.1.1
BP 2.2.1
bbP 2.5.5
Theme Twenty Twelve
PHP 5.5.12

#8 @johnjamesjacoby
4 years ago

You are correct. The fix was not applied to the 2.5 branch of code, so no fix was packaged into 2.5.5. It is in trunk, and will be in 2.6.

#9 @netweb
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Version changed from 2.5.5 to 2.0

Setting this back to fixed again, as noted above these changes are in the 2.6 branch.

#10 @netweb
4 years ago

  • Milestone changed from 2.6 to 2.5.8

This was added to the 2.5 branch in r5807 and will ship as part of bbPress 2.5.8

Note: See TracTickets for help on using tickets.