Skip to:

Opened 6 years ago

Closed 5 years ago

#2699 closed defect (fixed)

Closed topics throw php notice in page title

Reported by: wdfee Owned by: johnjamesjacoby
Milestone: 2.6 Priority: low
Severity: normal Version: 2.5.4
Component: Extend - BuddyPress Keywords: has-patch commit


In debug mode (test site) the browser page title doesn't work with closed topics.
bbp_filter_modify_page_title queries only posts with 'post_status' => 'publish'.
Solution: Allow 'post_status' => array('publish','closed')
(includes/extend/buddypress/functions.php 127)

Attachments (1)

2699.diff (873 bytes) - added by netweb 6 years ago.

Download all attachments as: .zip

Change History (3)

6 years ago

#1 @netweb
6 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.6

Thanks wdfee, patch attached fixes this and includes support for topic statuses publish, closed, spam, trash, and pending.

Note: We should have been able to use bbp_get_topic_statuses() for this but the current structure of that function needs to be modified to allow for this and is beyond the scope of this ticket.

#2 @johnjamesjacoby
5 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5849:

BuddyPress: Add all topic statuses to bbp_filter_modify_page_title().

This changeset fixes a bug that only allowed published topics to be queried in group forums.

Props netweb. Fixes #2699.

Note: See TracTickets for help on using tickets.