Skip to:
Content

Opened 5 years ago

Last modified 2 years ago

#2671 new defect

Emails being sent to noreply@www.mysite.com on forum subscription emails

Reported by: rossagrant Owned by:
Milestone: 2.7 Priority: normal
Severity: normal Version: 2.5.4
Component: API - Subscriptions Keywords: has-patch
Cc: info@…

Description

Hi guys,

I can recreate this on 2 sites and wonder if it's a bug.

When I create a topic in a forum that has users subscribed to it I keep getting a mail bounce back into my server inbox from my site.

It's an 'address not found' error that has been sent to noreply@… - so the www. is being added into the email address.

I'm using BP 2.0.2 and bbPress 2.5.4

To recreate:

  • subscribe to an entire forum.
  • post a new topic.
  • check your mail server's sent and inboxes.

Let me know if you can recreate it!

Ross :)

Attachments (1)

2671.01.patch (782 bytes) - added by r-a-y 2 years ago.

Download all attachments as: .zip

Change History (8)

#1 @r-a-y
5 years ago

See ticket:2162#comment:27.

I can duplicate this.

It's because bbPress sends a BCC email to all subscribers, but needs to set an email address for the $to parameter in wp_mail() so the email will actually send.

Not really a big fan of the BCC approach that bbPress has chosen to adopt for v2.5.4. I'll chime in on #2162 with further thoughts.

#2 @johnjamesjacoby
4 years ago

I wonder if we should just use the admin_email instead. It's more reliable, at least. :)

#3 @johnjamesjacoby
4 years ago

  • Milestone changed from Awaiting Review to 2.7

#4 @r-a-y
4 years ago

A better solution would be to use the tried-and-tested 'undiclosed-recipients;' for the $to address if we're using BCCs.

Unfortunately, WordPress needs to upgrade phpMailer to v5.2.8 so we can properly use it:
https://github.com/PHPMailer/PHPMailer/issues/201
https://core.trac.wordpress.org/ticket/28909

And there is resistance to upgrade to v5.2.8 any time soon without proper test coverage.

I guess I could open up a ticket for WP core to solely add in this patch:
https://github.com/PHPMailer/PHPMailer/issues/201

#5 @wdfee
4 years ago

  • Cc info@… added

#6 @r-a-y
2 years ago

Update: WordPress upgraded to PHPMailer 5.2.10 in WordPress 4.3, so we should be able to do what I mentioned in comment:4 now by wiping out the 'bbp_subscription_to_email' filter:
https://github.com/WordPress/WordPress/blob/4.3-branch/wp-includes/class-phpmailer.php#L1048

Attached patch does this.

@r-a-y
2 years ago

#7 @r-a-y
2 years ago

  • Keywords has-patch added
Note: See TracTickets for help on using tickets.