Skip to:
Content

Opened 5 years ago

Closed 5 years ago

#2652 closed enhancement (invalid)

Post meta key _bbp_reply_id is not created when creating new replies

Reported by: netweb Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Component - Replies Keywords:
Cc:

Description (last modified by netweb)

Currently replies do not have a post meta _bbp_reply_id key

Forums have _bbp_forum_id, topics have _bbp_topic_id, and reply to's have _bbp_reply_to meta keys.

The meta key _bbp_reply_id is implemented within bbp_update_reply_id() though this function is never called.

I think it makes sense based on the methodology used for our other post types and bbPress meta to include _bbp_reply_id for all new replies and updated/edited replies.

Related: #2647 Post meta key _bbp_forum_id is not created when creating new forums

Attachments (1)

2652.diff (1.7 KB) - added by netweb 5 years ago.

Download all attachments as: .zip

Change History (4)

@netweb
5 years ago

#1 @netweb
5 years ago

  • Description modified (diff)
  • Keywords 2nd-opinion added

In 2652.diff:

  • Introduce bbp_update_reply_reply_id() updater reply helper function
  • bbp_update_reply() calls bbp_update_reply_reply_id() to add _bbp_reply _id post meta key when a reply is created or edited using bbp_new_reply_handler() and bbp_edit_reply_handler() respectively

We should also updating existing reply meta as part of the bbPress 2.6 update.

We should also add a repair tool bbp_admin_repair_reply_meta() for repairing reply meta data alongside fellow bbp_admin_repair_forum_meta() and bbp_admin_repair_topic_meta() repair tools.

This ticket was mentioned in IRC in #bbpress-dev by netweb. View the logs.


5 years ago

#3 @netweb
5 years ago

  • Keywords needs-patch 2nd-opinion removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.