Skip to:
Content

Opened 5 years ago

Last modified 17 months ago

#2635 new defect

Accessibility: Templates - Breadcrumbs

Reported by: netweb Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version:
Component: General - Accessibility Keywords:
Cc: mercijavier@…

Description

via Karl Groves bbPress Accessibility Feedback https://gist.github.com/ntwb/c8f99df8a714ed028e2d

Suggested breadcrumb markup
Note: The stuff in the breadcrumb separator span should be CSS generated content.
In the following model it'd be: .bbp-breadcrumb ul li a::after{ content: ' ›'; }

Proposed:

<div class="bbp-breadcrumb">
    <ul>
        <li><a href="http://wp-test:8888/" class="bbp-breadcrumb-home">Home</a></li>
        <li><a href="http://wp-test:8888/?post_type=forum" class="bbp-breadcrumb-root">Forums</a></li>
        <li><span class="bbp-breadcrumb-current">Developers – General</span></li>
    </ul>
</div>

Current:

<div class="bbp-breadcrumb">
    <p>
        <a href="http://wp-test:8888/" class="bbp-breadcrumb-home">Home</a>
        <span class="bbp-breadcrumb-sep"></span>
        <a href="http://wp-test:8888/?post_type=forum/" class="bbp-breadcrumb-root">Forums</a>
        <span class="bbp-breadcrumb-sep"></span>
        <span class="bbp-breadcrumb-current">Developers – General</span>
    </p>
</div>

Attachments (2)

2635.patch (1.5 KB) - added by Robkk 3 years ago.
Uses ordered list instead and some different CSS.
2635-2.patch (1.6 KB) - added by Robkk 3 years ago.
Back to using unordered list.

Download all attachments as: .zip

Change History (8)

#1 @netweb
5 years ago

A basic plugin to achieve 'close' to the intended results is here: https://gist.github.com/ntwb/fe3dec3ac219cd0ef322

It needs some CSS tweaks though the HTML of the breadcrumbs is:

<div class="bbp-breadcrumb">
    <ul>
        <li><a href="http://wp-test:8888/" class="bbp-breadcrumb-home">Home</a></li>
        <li><a href="http://wp-test:8888/forums/" class="bbp-breadcrumb-root">Forums</a></li>
        <li><span class="bbp-breadcrumb-current">Developers – General</span></li>
    </ul>
</div>

As to a patch for this ticket in it's current form by moving the separator to CSS is unlikely.

Users have the ability as the above plugin shows to customize the breadcrumbs quite significantly already and this includes the separator character, 'out of the box' bbPress also supports LTR and RTL:

$args['sep'] = is_rtl() ? __( '&lsaquo;', 'bbpress' ) : __( '&rsaquo;', 'bbpress' );

Moving the separator to CSS using a::after{ content: ' ›'; } will remove the ability for users to filter the separator and will break backwards compatibility and not allow us to switch separators for RTL CSS.

Changing the default breadcrumbs to use a list item format (using the defaults per the above plugin) should be fine.

#2 @mercime
5 years ago

  • Cc mercijavier@… added

#3 @johnjamesjacoby
4 years ago

  • Component changed from Theme Compatability to Accessibility
  • Milestone changed from Awaiting Review to 2.7

Bumping to 2.7 so we can clear out Awaiting Review and 2.6 milestones.

#4 @johnjamesjacoby
4 years ago

  • Milestone changed from 2.7 to 2.8

Bumping all 2.7 to 2.8 milestone.

@Robkk
3 years ago

Uses ordered list instead and some different CSS.

@Robkk
3 years ago

Back to using unordered list.

#5 @netweb
3 years ago

Related: #2269

This ticket was mentioned in Slack in #bbpress by netweb. View the logs.


17 months ago

Note: See TracTickets for help on using tickets.