Skip to:
Content

Opened 5 years ago

Closed 4 years ago

#2633 closed defect (fixed)

Accessibility: Tabindex – Remove all instances of tab index from bbPress

Reported by: netweb Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General - Accessibility Keywords:
Cc: mercijavier@…

Description

via Karl Groves bbPress Accessibility Feedback https://gist.github.com/ntwb/c8f99df8a714ed028e2d

Eliminate tabindex in any case where it is > 0


They almost always result in decreased accessibility. Even when implemented properly (which is rare), they are typically used to account for poor design decisions. For instance, the natural navigation order is illogical, so tabindex is used to fix it. Or search is not prevalent within the page, so accesskey is implemented to provide quicker access to it. The benefits of accesskey and tabindex rarely outweigh the problems they introduce.

Related: #WP19930 tabindex does not help accessibility at all.

Attachments (1)

2633.diff (47.2 KB) - added by netweb 5 years ago.

Download all attachments as: .zip

Change History (8)

@netweb
5 years ago

#1 @netweb
5 years ago

In 2633.diff:

First pass at removing tabindex from bbPress

  • Removes all 'tabindex' from template form fields and widgets
  • Removes the TinyMCE tabfocus plugin
  • Removes jQuery javascript for bbp_topic_title and bbp_topic_tags tab focus

Still a couple of things to do here including depreciate bbp_tab_index() and bbp_get_tab_index()

#2 @netweb
5 years ago

Via WordPress Theme Accesibility Guidelines http://make.wordpress.org/themes/guidelines/guidelines-accessibility/

Not Allowed

  • The tabindex attribute, excepting negative or zero tabindex in specific circumstances (assessed on a case-by-case basis).

#3 @mercime
5 years ago

  • Cc mercijavier@… added

#4 @johnjamesjacoby
4 years ago

  • Component changed from Theme Compatability to Accessibility
  • Milestone changed from Awaiting Review to 2.7

Bumping to 2.7 so we can clear out Awaiting Review and 2.6 milestones.

#5 @johnjamesjacoby
4 years ago

  • Milestone changed from 2.7 to 2.8

Bumping all 2.7 to 2.8 milestone.

This ticket was mentioned in Slack in #bbpress by netweb. View the logs.


4 years ago

#7 @johnjamesjacoby
4 years ago

  • Milestone 2.8 deleted
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in #2714.

Thanks everyone!

Note: See TracTickets for help on using tickets.