Skip to:
Content

Opened 5 years ago

Closed 4 years ago

#2625 closed defect (fixed)

New reply legend shouldn't say Create New Topic in "" if forum title is blank

Reported by: jreeve Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: trivial Version:
Component: General Keywords:
Cc:

Description

I'm using bbPress with Buddypress, and making group forums that have the same names as their groups. On a group forum topic listing, the name of the group is at the top of the page, and then the name of the forum (which is the same thing) is below it. This was redundant, so I filtered the forum title out by filtering bbp_get_forum_title() and having it return nothing. Admittedly, not the cleanest hack. But this makes the new reply legend say Create New Topic in "", i.e., with empty quotation marks. This shouldn't happen, so I added a check to the line that creates this output, to make sure that the forum title isn't empty before trying to print it.

This is my first time submitting a patch on Trac (I'm more of a github guy), so let me know if I did this right!

Attachments (1)

form-topic.patch (678 bytes) - added by jreeve 5 years ago.

Download all attachments as: .zip

Change History (3)

@jreeve
5 years ago

#1 @johnjamesjacoby
4 years ago

  • Milestone changed from Awaiting Review to 2.6

Looks good to me. Let's get this into 2.6. Thanks for the patch!

#2 @johnjamesjacoby
4 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5478:

In the form-topic.php template part, check for 'bbp_get_forum_title()` before outputting an empty title. Props jreeve. Fixes #2625.

Note: See TracTickets for help on using tickets.