Skip to:
Content

bbPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2620 closed defect (fixed)

Undefined index $user_Id

Reported by: mordauk Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: trunk
Component: API - Subscriptions Keywords: has-patch
Cc:

Description

The changes to the subscription handler in 2162 have caused a few undefined index errors:

`
Notice: Undefined variable: user_id in /Users/pippinwilliamson/Sites/trunk/wp-content/plugins/bbpress/includes/common/functions.php on line 1225

Notice: Undefined variable: user_id in /Users/pippinwilliamson/Sites/trunk/wp-content/plugins/bbpress/includes/common/functions.php on line 1231
`

Those happen whenever a new reply is posted.

Attachments (1)

2620.patch (898 bytes) - added by mordauk 5 years ago.

Download all attachments as: .zip

Change History (7)

@mordauk
5 years ago

#1 @mordauk
5 years ago

  • Keywords has-patch added; needs-patch removed

I'd propose just setting $user_id to null since it can no longer be used in the way it was before.

#2 @netweb
5 years ago

  • Milestone changed from Awaiting Review to 2.6

Thanks Pippin,

Duplicate #2619

#3 @Faison
5 years ago

I just wanted to add that this also occurs when posting a new topic

#4 @johnjamesjacoby
5 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5417:

Add default value for $user_id to prevent debug notice when sending subscription notifications. Props mordauk. Fixes #2620.

#5 @netweb
5 years ago

#2720 Was marked as a duplicate

This ticket was mentioned in Slack in #bbpress by netweb. View the logs.


5 years ago

Note: See TracTickets for help on using tickets.