Skip to:
Content

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#2609 closed defect (fixed)

topic not included when post__not_in is set

Reported by: mikelopez Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5.3
Component: General Keywords:
Cc:

Description

Hi,

My name is Mike Lopez, Lead Developer for WishList Products.

We have a few clients reporting that bbPress is not displaying the post topic for regular members. We investigated the matter and narrowed the problem to the _bbp_has_replies_where function in bbpress/includes/replies/functions.php in bbPress version 2.5.3

Apparently, the function does not do it's thing if post__not_in is set. I think this issue will also appear if some other plugin specifies a post__not_in, not just WishList Member.

I've attached a patch file for bbpress/includes/replies/functions.php which so far seems to fix the issue. Kindly see if the patch I made will not affect other parts of bbPress. Thus far, I haven't seen any adverse effects but you know your code better.

Thank you very much.

Mike

Attachments (1)

functions.php.patch (726 bytes) - added by mikelopez 5 years ago.
Patch for bbpress/includes/replies/functions.php (version 2.5.3)

Download all attachments as: .zip

Change History (3)

@mikelopez
5 years ago

Patch for bbpress/includes/replies/functions.php (version 2.5.3)

#1 @johnjamesjacoby
4 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5476:

In _bbp_has_replies_where() remove the post__not_in check and add extra search/replace arguments for more complex queries. Improves support for popular privacy plugins that frequently use post__not_in. Props mikelopez. Fixes #2609.

#2 @johnjamesjacoby
4 years ago

  • Milestone changed from Awaiting Review to 2.6
Note: See TracTickets for help on using tickets.