Skip to:
Content

bbPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 17 months ago

#2583 closed defect (fixed)

bbPress Mint and Evergreen WordPress Core upstream SCSS updates

Reported by: netweb Owned by: netweb
Milestone: 2.6 Priority: normal
Severity: normal Version: trunk
Component: Appearance - Included Themes Keywords: commit
Cc:

Description (last modified by netweb)

Before shipping a new bbPress release we need to ensure that bbPress Mint and Evergreen admin themes are up to date with the latest upstream changes by WordPress Core.

This is a rolling ticket for the bbPress 2.6 Milestone.

This ticket should be closed and considered fixed prior to releasing bbPress 2.6.

https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/colors
https://bbpress.trac.wordpress.org/browser/trunk/src/includes/admin/styles

The following three bbPress files are kept in sync with same file names via WordPress Core

https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/colors/_admin.scss
https://bbpress.trac.wordpress.org/browser/trunk/src/includes/admin/styles/_admin.scss

https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/colors/_mixins.scss
https://bbpress.trac.wordpress.org/browser/trunk/src/includes/admin/styles/_mixins.scss

https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/colors/_variables.scss
https://bbpress.trac.wordpress.org/browser/trunk/src/includes/admin/styles/_variables.scss


These files are rarely/historically updated so this shouldn't be an issue often, that said in future iteration we should be able to have our build tools build from WordPress' source files rather than including these in bbPress.

Attachments (2)

2583.diff (3.7 KB) - added by netweb 5 years ago.
2583.2.diff (3.9 KB) - added by netweb 5 years ago.

Download all attachments as: .zip

Change History (24)

@netweb
5 years ago

#1 @netweb
5 years ago

Refreshed patch via r28122

@netweb
5 years ago

#2 @netweb
5 years ago

2583.2.diff​ refreshed patch via r28127

#3 @netweb
5 years ago

  • Owner set to netweb
  • Resolution set to fixed
  • Status changed from new to closed

In 5343:

Updated base admin styles SCSS

Fixes #2583

#4 @netweb
5 years ago

  • Description modified (diff)
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Summary changed from Update admin colors scss to bbPress Mint and Evergreen WordPress Core upstream SCSS updates

#5 @netweb
5 years ago

  • Status changed from reopened to new

#6 @netweb
5 years ago

In 5419:

Updated _admin.scss via WP:changeset:28861. See #2583

#7 @netweb
5 years ago

In 5430:

Updated _admin.scss via WP:changeset:29031. See #2583

#8 @netweb
5 years ago

In 5447:

Updated _admin.scss via WP:changeset:29124 and WP:changeset:29287. See #2583

#9 @netweb
5 years ago

In 5459:

Updated _admin.scss via WP:changeset:29542. See #2583

#10 @netweb
5 years ago

In 5479:

Updated _mixins.scss via WP:changeset:29616, WP:changeset:29648. See #2583

#12 follow-up: @johnjamesjacoby
5 years ago

Thanks for keeping an eye on these. Looks like we're up to speed with WordPress 4.0 now?

#13 in reply to: ↑ 12 @netweb
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Replying to johnjamesjacoby:

Thanks for keeping an eye on these. Looks like we're up to speed with WordPress 4.0 now?

Yep, I doubt we will see any more changes in WordPress Core before we release bbPress 2.6.

#14 @netweb
5 years ago

In 5582:

Updated _admin.scss via WP:changeset:30531. See #2583

#15 @netweb
5 years ago

In 5620:

Updated _admin.scss via WP:changeset:31564. See #2583

#16 @netweb
5 years ago

In 5635:

Updated _admin.scss via WP:changeset:31648 for grunt-sass v0.18.0 compatibility via r5624 See #2583

#17 @netweb
4 years ago

In 5803:

Updated admin base SCSS styles:

See #2583

#19 @netweb
3 years ago

In 5993:

Updated admin base SCSS styles:

See #2583

#20 @netweb
3 years ago

In 6214:

Appearance - Included Themes: Update admin base SCSS styles:

See #2583

#21 @netweb
2 years ago

In 6539:

Updated admin base SCSS styles:

See #2583

#22 @netweb
17 months ago

In 6818:

Appearance - Included Themes: Updated admin base SCSS styles:

See #2583.

Note: See TracTickets for help on using tickets.