Skip to:
Content

Opened 5 years ago

Closed 4 years ago

#2575 closed defect (fixed)

Add whitespace between breadcrumb and forum subscribe link

Reported by: netweb Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5
Component: Component - Forums Keywords: has-patch
Cc:

Description

Add whitespace between breadcrumb and forum subscribe link

Attached image 2575.png shows before (top) and after (bottom)

Attachments (2)

2575.png (1.3 KB) - added by netweb 5 years ago.
2575.diff (691 bytes) - added by netweb 5 years ago.

Download all attachments as: .zip

Change History (8)

@netweb
5 years ago

@netweb
5 years ago

This ticket was mentioned in IRC in #bbpress-dev by netweb. View the logs.


5 years ago

#2 @johnjamesjacoby
5 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5403:

Normalize Favorite and Subscribe links for Forums and Topics so they are visually linear to the breadcrumb. Hat-tip netweb. Fixes #2575.

#3 @netweb
5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This doesn't fix the original issue for the forum subscription link of adding 'something' (the patch adds a non-break space) between the forum title and forum subscribe link.
https://i.cloudup.com/ftm1jNMgHW.png

r5403 is changing the topic subscription link and I think this should be reverted for now.

I think we can improve on the implementation in r5403 and per #2581 we need to fix various aspects of the favorite and subscription links and filters.

How things currently look with r5403, the separator | is in the wrong place, long titles it moves to a new line etc.
https://i.cloudup.com/V_zNUT-Am7.png
https://i.cloudup.com/hd21TYqBF0.png
https://i.cloudup.com/vv0xRvkx2t.png

#4 @johnjamesjacoby
5 years ago

It looks like you didn't run grunt to reload the updated styles that float those links to the right

#5 @netweb
5 years ago

Ha! Your correct ;) Moving right along... Floats right now, no separator between topic tags

https://i.cloudup.com/uiHM3dicBk.png

#6 @netweb
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.