Skip to:
Content

Opened 5 years ago

Closed 5 years ago

#2510 closed defect (fixed)

Remove hardcoded post type references in tools.php

Reported by: thebrandonallen Owned by: thebrandonallen
Milestone: 2.6 Priority: normal
Severity: normal Version: trunk
Component: Tools Keywords: commit
Cc:

Description

Discovered these working on #1925.

Attachments (1)

2510.01.diff (18.3 KB) - added by thebrandonallen 5 years ago.

Download all attachments as: .zip

Change History (3)

#1 @johnjamesjacoby
5 years ago

  • Keywords commit added; has-patch removed
  • Milestone changed from Awaiting Review to 2.6

Patch looks good to me. Thank you!

(An aside, the converter also uses hardcoded values, and I think it's best to leave them hardcoded there for now, so there is no mistake about the conversion process. If someone wants custom values, they can easily run some fixer queries once the conversion is complete.)

#2 @netweb
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 5253:

Remove hard coded post type references in repair tools. Props thebrandonallen. Fixes #2510

Note: See TracTickets for help on using tickets.