Skip to:
Content

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2509 closed enhancement (fixed)

form-reply shows topic title for reply to reply instead of post number

Reported by: artkahlich Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: trunk
Component: Component - Replies Keywords: needs-patch needs-ui
Cc: nashwan.doaqan@…

Description

The legend of form-reply.php gives no indication of the difference between a reply to topic versus a reply to a reply. I have to look at the URL displayed by the browser to tell the difference. This is really confusing to both my moderators and users.

Current behavior shows the legend always as:

Reply To: <topic>

When I would expect a reply to reply 400 to change the legend to:

Reply To: #400

I see the code in:

http://bbpress.svn.wordpress.org/trunk/templates/default/bbpress/form-reply.php

the line:

<legend><?php printf( ( 'Reply To: %s', 'bbpress' ), bbp_get_topic_title() ); ?></legend>

Should a reply to a reply should use a different function like bbp_get_form_reply_to()? See:

http://bbpress.svn.wordpress.org/trunk/includes/replies/template.php

Is there an easy way to test for being in a reply to a reply versus a reply to a topic?

Attachments (1)

2509.1.diff (1.1 KB) - added by netweb 5 years ago.

Download all attachments as: .zip

Change History (13)

#1 @artkahlich
5 years ago

The modification of the legend for a reply to a reply could also be in the form of:

Reply To: #400 in <topic>

#2 @johnjamesjacoby
5 years ago

  • Keywords needs-patch needs-ui added
  • Milestone changed from Awaiting Review to 2.6
  • Type changed from defect to enhancement

That's a great enhancement. Anyone up for patching this quickly for 2.6?

#3 @netweb
5 years ago

  • Owner set to netweb
  • Status changed from new to assigned

I'll take a shot at this tomorrow

#5 @artkahlich
5 years ago

I am looking forward to this. I already have a number of claims that threading is broken, and I wonder how many of them are bogus because the claimant did not know that he/she was replying to topic instead of to the intended reply.

#6 @alex-ye
5 years ago

  • Cc nashwan.doaqan@… added

@netweb
5 years ago

#7 follow-up: @netweb
5 years ago

  • Owner netweb deleted
  • Status changed from assigned to new

In 2509.1.diff

A threaded reply output in form-reply.php
Reply To Reply #95945 in Topic Test Two Zero Five Nine

A standard reply output in form-reply.php
Reply To: Topic Test Two Zero Five Nine

The patch works fine without reply.js, the JavaScript side of this is beyond me :(

Either the required JavaScript changes need to be added or a patch using a different method would be required.

#8 in reply to: ↑ 7 ; follow-up: @netweb
5 years ago

Replying to netweb:

The patch works fine without reply.js, the JavaScript side of this is beyond me :(

I should have added why, when the reply form is moved to below the reply you are replying to the value of bbp_get_form_reply_to gets nuked.

#9 in reply to: ↑ 8 @johnjamesjacoby
5 years ago

Replying to netweb:

Replying to netweb:

The patch works fine without reply.js, the JavaScript side of this is beyond me :(

I should have added why, when the reply form is moved to below the reply you are replying to the value of bbp_get_form_reply_to gets nuked.

Makes sense. Won't take much JS to fix this little bit.

#10 @netweb
5 years ago

  • Owner set to johnjamesjacoby

#11 @johnjamesjacoby
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 5397:

If a reply is a reply to another reply, display the parent reply information in the form legend with the topic title. Props netweb. Fixes #2509.

This ticket was mentioned in IRC in #bbpress-dev by netweb. View the logs.


5 years ago

Note: See TracTickets for help on using tickets.