Skip to:
Content

bbPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#2508 closed defect (fixed)

Wrong format 'string' (should be 'simple') passed in bbp_format_buddypress_notifications()

Reported by: lakrisgubben Owned by:
Milestone: 2.5.3 Priority: normal
Severity: normal Version: trunk
Component: Extend - BuddyPress Keywords:
Cc:

Description

I had a problem where users where complaining about a notification that just said "array", seems to be when someone replies to a forum thread and when it is the buddybar that prints the notifications.

As far as I can tell this has to do with the function bbp_format_buddypress_notifications() that passes $format = 'string' on row http://bbpress.trac.wordpress.org/browser/trunk/includes/extend/buddypress/notifications.php#L41
and checks for 'string' on row http://bbpress.trac.wordpress.org/browser/trunk/includes/extend/buddypress/notifications.php#L63

But the BuddyPress function bp_notifications_get_notifications_for_user() ( https://buddypress.trac.wordpress.org/browser/trunk/bp-notifications/bp-notifications-functions.php#L121 ) expects $format to be 'simple'.

When I change 'string' to 'simple' it seems to work...

Change History (4)

#1 @johnjamesjacoby
6 years ago

  • Milestone changed from Awaiting Review to 2.5.3

Confirmed. Moving to 2.5.3.

#2 @johnjamesjacoby
6 years ago

Will need to be fixed in BuddyPress. Commits incoming.

#3 @johnjamesjacoby
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Closing as fixed. Will be in a future BuddyPress release.

Note: See TracTickets for help on using tickets.