Skip to:
Content

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2493 closed defect (fixed)

Topic Subscribed status is not being kept after a new reply is created

Reported by: netweb Owned by: johnjamesjacoby
Milestone: 2.5.3 Priority: normal
Severity: normal Version: 2.5.1
Component: API - Subscriptions Keywords: needs-patch
Cc:

Description

Topic Subscriptions behaving badly!

Repro

  • Subscribe to a topic via the topic 'subscribe' link
  • Ensure that you now see 'Subscribed'
  • Post a reply without checking the 'Notify me of follow-up replies via email' checkbox
  • Check the topic's 'Subscribe' link and you will see it displayed as 'Subscribe' and you are no longer subscribed to the topic

Expected

  • 'Subscribe' link should still be showing as 'Subscribed' and you should remain subscribed to the topic.

Will take a look around the code tomorrow.

Attachments (1)

2493.patch (2.8 KB) - added by johnjamesjacoby 5 years ago.

Download all attachments as: .zip

Change History (6)

#1 @netweb
5 years ago

Workaround

  • When replying to a topic check the 'Notify me of follow-up replies via email' checkbox when submitting a new reply.

#2 @johnjamesjacoby
5 years ago

My guess is this has something to do with under the hood changes to bbp_is_user_subscribed() when forum subscriptions were introduced. Looking into it.

#3 @johnjamesjacoby
5 years ago

  • Milestone changed from Awaiting Review to 2.5.3

#4 @johnjamesjacoby
5 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5236:

Use more explicit subscriptions functions for form output. Fixes #2493. (trunk)

#5 @johnjamesjacoby
5 years ago

In 5237:

Use more explicit subscriptions functions for form output. Fixes #2493. (2.5 branch)

Note: See TracTickets for help on using tickets.